Review main Merged

67456[BUGFIX] Fix accessibility issues of system news

Martin Kutschker CR +2 V +2 Normal +52 −44 updated 02/15/21, 09:44

Commit message

The system news slider implements the ARIA pattern "carousel"
except for the omission of aria-roledescription which has
no support in current screen readers.

Additionally the contrast of the slider controls has been
increased and the click size does not shrink on small screens.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 5

Review log 1525

  1. Martin Kutschker uploaded patch set 1 01/16/21, 14:32

  2. TYPO3com voted on patch set 1 V -1 01/16/21, 14:42 Completed build in 09m 49s on Sat, 16 Jan, 02:42 PM Test Summary: 32579 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8880

  3. Martin Kutschker uploaded patch set 2 01/31/21, 17:44

  4. Martin Kutschker updated the commit message in patch set 3 01/31/21, 17:44

  5. Martin Kutschker wrote 01/31/21, 17:44

    Topic set to a11y
  6. Martin Kutschker updated the commit message in patch set 4 01/31/21, 17:45

  7. TYPO3com voted on patch set 2 V -1 01/31/21, 17:55 Completed build in 10m 29s on Sun, 31 Jan, 05:55 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9119

  8. TYPO3com voted on patch set 3 V -1 01/31/21, 17:57 Completed build in 12m 02s on Sun, 31 Jan, 05:57 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9120

  9. TYPO3com voted on patch set 4 V -1 01/31/21, 18:01 Completed build in 15m 44s on Sun, 31 Jan, 06:01 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9121

  10. TYPO3com commented on patch set 4 01/31/21, 19:28 Completed build in 09m 17s on Sun, 31 Jan, 07:28 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9123

  11. Martin Kutschker uploaded patch set 5 01/31/21, 20:30

  12. TYPO3com voted on patch set 5 V +1 01/31/21, 20:40 Completed build in 09m 37s on Sun, 31 Jan, 08:40 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9125

  13. Oliver Hader commented on patch set 5 02/01/21, 07:47

    LoginNews.html:20 Unresolved

    Just a side-note: Using `{loginNewsIterator.isFirst ? ' active' : ''}` allow to skip some view-helper boilerplate
  14. Martin Kutschker uploaded patch set 6 02/13/21, 15:51

  15. TYPO3com voted on patch set 6 V +1 02/13/21, 15:58 Completed build in 06m 25s on Sat, 13 Feb, 03:58 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9515

  16. core-ci voted on patch set 6 V +1 02/13/21, 16:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/703

  17. Guido Schmechel commented on patch set 6 02/14/21, 18:12

    Hint: If there is more than one item, the carousel works like expected :-)

    LoginNews.html:27

    The case "One news" could have a little more love. Here just a local try: <div class="p-4"> <f:render section="Item" arguments="{item:'{loginNewsItems.0}'}" /> </div>

    LoginNews.html:36

    I know that this is a behavior like before. But could we add an if condition to display the date only if set?
  18. Benni Mack uploaded patch set 7 02/15/21, 07:49

  19. TYPO3com voted on patch set 7 V +1 02/15/21, 07:56 Completed build in 07m 47s on Mon, 15 Feb, 07:56 AM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9529

  20. core-ci voted on patch set 7 V +1 02/15/21, 08:00 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/720

  21. Benni Mack voted on patch set 7 V +1 CR +1 02/15/21, 08:23

  22. Richard Haeser voted on patch set 7 V +2 CR +2 02/15/21, 08:53

  23. Richard Haeser merged patch set 8 02/15/21, 08:54

  24. Richard Haeser commented on patch set 8 02/15/21, 09:33

  25. Richard Haeser commented on patch set 8 02/15/21, 09:44

    LoginNews.html:27 Reply

    Done

    LoginNews.html:36 Reply

    This is the crdate which will always be set (if you don't specify it in the properties, it will use the current date). So no check needed.