Review main Merged

67457[TASK] Remove jQuery from Permissions module

Andreas Kienast CR +2 V +2 Hard +199 −184 updated 01/19/21, 13:09

Commit message

The Permissions backend module and its JavaScript module now ditch jQuery
in favor of native browser API and TYPO3 API.

The JavaScript has been refactored a little bit; initially checking the
permission checkboxes or writing back the calculcated permission value
is now decoupled and executed in the Permission module only.

To support for..of with NodeList collections, TypeScript now loads the
internal "dom.iterable" library.

Additionally, the interim solution to add `editform` to Document has
been removed which made another change in LinkPopup necessary.

Furthermore, a bug has been fixed, where the value of the first
visible select element was used when saving any other select element
with a completely different value.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1117

  1. Andreas Kienast uploaded patch set 1 01/16/21, 17:22

  2. Andreas Kienast commented on patch set 1 CR -1 01/16/21, 17:28

    I forgot some jQuery parts, obviously
  3. TYPO3com voted on patch set 1 V +1 01/16/21, 17:32 Completed build in 10m 30s on Sat, 16 Jan, 05:32 PM Test Summary: 32579 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8882

  4. Andreas Kienast uploaded patch set 2 01/16/21, 18:02

  5. Andreas Kienast uploaded patch set 3 01/16/21, 18:06

  6. TYPO3com voted on patch set 2 V +1 01/16/21, 18:12 Completed build in 09m 12s on Sat, 16 Jan, 06:12 PM Test Summary: 32579 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8883

  7. TYPO3com voted on patch set 3 V -1 01/16/21, 18:15 Completed build in 08m 25s on Sat, 16 Jan, 06:15 PM Test Summary: 32579 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8884

  8. Andreas Kienast uploaded patch set 4 01/16/21, 18:42

  9. TYPO3com voted on patch set 4 V +1 01/16/21, 18:53 Completed build in 11m 39s on Sat, 16 Jan, 06:53 PM Test Summary: 32579 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8885

  10. Benni Mack voted on patch set 4 V +1 CR +1 01/17/21, 11:51

  11. Oli Bartsch commented on patch set 4 V -1 01/19/21, 11:16

    Changing group access has some side effects (e.g. setting <span class="not_set">[not set]</span> as group name). Will have a look.
  12. Oli Bartsch uploaded patch set 5 01/19/21, 12:46

  13. Oli Bartsch voted on patch set 5 V +1 CR +1 01/19/21, 12:51

  14. TYPO3com voted on patch set 5 V -1 01/19/21, 12:54 Completed build in 08m 10s on Tue, 19 Jan, 12:54 PM Test Summary: 1 of 32836 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8914

  15. TYPO3com voted on patch set 5 V +1 01/19/21, 13:04 Completed build in 26m 02s on Tue, 19 Jan, 01:04 PM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8914

  16. Benni Mack voted on patch set 5 V +2 CR +2 01/19/21, 13:09

  17. Benni Mack merged patch set 6 01/19/21, 13:09