Review main Merged

67458[FEATURE] Use dropdown for secondary action items

Benni Mack CR +2 V +2 Hard +197 −194 updated 06/21/21, 19:30

Commit message

This change replaces the "collapse-horizontal" functionality
of the extended view icons into a dropdown from Bootstrap,
allowing users to understand the icons better because the
text is now also written next to the icon (similar to
the Context Menu).

The horizontal collapsing is removed as a UX improvement
to
a) give consistency around other areas in TYPO3 Backend
b) was intended as a workaround to solve the Extended View rendering and to avoid button-hell
c) avoid confusion around editors when buttons are visually moving horizontally
d) the Extended View feature was unclear for editors when to enable it

In addition the "View" link is now moved into the secondary button group.

The Extended View checkbox is therefore removed as all secondary
options are always available.

Same functionality is also replaced in the File List module to use
the "..." icon to show that there are more actions available.

Side note: The dropdown needs a position-static due to
overflow-x: auto - see https://github.com/twbs/bootstrap/issues/29313#issuecomment-758412385

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 2544

Show 919 earlier messages
  1. Benni Mack uploaded patch set 1 01/17/21, 11:06

  2. Benni Mack uploaded patch set 2 01/17/21, 11:07

  3. TYPO3com voted on patch set 1 V -1 01/17/21, 11:16 Completed build in 10m 26s on Sun, 17 Jan, 11:16 AM Test Summary: 18 of 32820 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8892

  4. TYPO3com voted on patch set 2 V -1 01/17/21, 11:19 Completed build in 12m 21s on Sun, 17 Jan, 11:19 AM Test Summary: 19 of 32820 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8893

  5. Benni Mack uploaded patch set 3 01/20/21, 16:03

  6. TYPO3com voted on patch set 3 V -1 01/20/21, 16:16 Completed build in 10m 44s on Wed, 20 Jan, 04:16 PM Test Summary: 18 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8938

  7. Benni Mack uploaded patch set 4 01/21/21, 21:03

  8. TYPO3com voted on patch set 4 V -1 01/21/21, 21:04 Completed build in 19s on Thu, 21 Jan, 09:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8974

  9. Benni Mack uploaded patch set 5 02/01/21, 21:55

  10. TYPO3com voted on patch set 5 V -1 02/01/21, 22:26 Completed build in 12m 23s on Mon, 1 Feb, 10:26 PM Test Summary: 18 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9186

  11. Benni Mack uploaded patch set 6 02/08/21, 07:14

  12. TYPO3com voted on patch set 6 V -1 02/08/21, 07:22 Completed build in 08m 02s on Mon, 8 Feb, 07:22 AM Test Summary: 18 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9342

  13. core-ci voted on patch set 6 V -1 02/08/21, 07:26 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/471

  14. Benni Mack uploaded patch set 7 05/05/21, 14:20

  15. core-ci voted on patch set 7 V -1 05/05/21, 14:40 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11217

  16. Benni Mack uploaded patch set 8 06/12/21, 19:13

  17. core-ci voted on patch set 8 V +1 06/12/21, 19:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12340

  18. Benni Mack uploaded patch set 9 06/21/21, 09:28

  19. core-ci voted on patch set 9 V +1 06/21/21, 09:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12619

  1. Benni Mack uploaded patch set 10 06/21/21, 10:14

  2. core-ci voted on patch set 10 V +1 06/21/21, 10:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12624

  3. Benni Mack uploaded patch set 11 06/21/21, 12:07

  4. core-ci voted on patch set 11 V -1 06/21/21, 12:19 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12625

  5. Benni Mack uploaded patch set 12 06/21/21, 13:26

  6. Benni Mack uploaded patch set 13 06/21/21, 13:32

  7. core-ci voted on patch set 12 V -1 06/21/21, 13:39 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12629

  8. core-ci voted on patch set 13 V -1 06/21/21, 13:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12630

  9. Benni Mack uploaded patch set 14 06/21/21, 14:11

  10. Benni Mack uploaded patch set 15 06/21/21, 14:13

  11. core-ci voted on patch set 14 V +1 06/21/21, 14:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12634

  12. core-ci voted on patch set 15 V +1 06/21/21, 14:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12635

  13. Andreas Kienast commented on patch set 15 CR -1 06/21/21, 15:00

    on it
  14. Andreas Kienast uploaded patch set 16 06/21/21, 15:04

  15. Andreas Kienast uploaded patch set 17 06/21/21, 15:07

  16. Andreas Kienast voted on patch set 17 V +1 CR +1 06/21/21, 15:08

  17. core-ci voted on patch set 16 V +1 06/21/21, 15:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12637

  18. core-ci voted on patch set 17 V +1 06/21/21, 15:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12638

  19. Oli Bartsch commented on patch set 17 V -1 06/21/21, 16:03

    Dropdown is cut off in filelist. Will have a look.
  20. Oli Bartsch commented on patch set 17 06/21/21, 16:50

    Reply Unresolved

    Couldn't find a reason for now. This however only happens in case just a few files/folders are present in the list.
  21. Benni Mack uploaded patch set 18 06/21/21, 19:04

  22. core-ci voted on patch set 18 V +1 06/21/21, 19:14 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12652

  23. Oli Bartsch voted on patch set 18 V +1 CR +1 06/21/21, 19:27

  24. Andreas Kienast voted on patch set 18 V +2 CR +2 06/21/21, 19:30

  25. Andreas Kienast merged patch set 19 06/21/21, 19:30