Review main Merged

67459[BUGFIX] Re-add proper badges for toolbar items

Benni Mack CR +2 V +2 Easy +4 −4 updated 01/18/21, 09:00

Commit message

The opendocs toolbar item does not have a badge background anymore,
this changes re-adds the background and also unifies
the badge from the system information toolbar to use
the rounded-pill class.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 56

  1. Benni Mack uploaded patch set 1 01/17/21, 11:25

  2. TYPO3com voted on patch set 1 V +1 01/17/21, 11:34 Completed build in 09m 11s on Sun, 17 Jan, 11:34 AM Test Summary: 32589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8894

  3. Riccardo De Contardi commented on patch set 1 V +1 01/17/21, 15:02

    Tested with recent document badge and error badge; both have background and are "pills"
  4. Oli Bartsch voted on patch set 1 V +1 CR +1 01/18/21, 08:16

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 01/18/21, 09:00

  6. Christian Kuhn merged patch set 2 01/18/21, 09:00