Review main Merged

67460[TASK] Use buttons in Permissions module

Oli Bartsch CR +2 V +2 Normal +47 −41 updated 01/20/21, 21:10

Commit message

The permissions module previously used a lot of
anchor elements without a target defined.

To improve accessibility and semantic correctness
these selectors are now changed to button tags.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 612

  1. Oli Bartsch uploaded patch set 1 01/18/21, 09:40

  2. Oli Bartsch wrote 01/18/21, 09:41

    Topic set to a11y
  3. TYPO3com voted on patch set 1 V -1 01/18/21, 09:50 Completed build in 09m 14s on Mon, 18 Jan, 09:50 AM Test Summary: 1 of 32830 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8903

  4. TYPO3com voted on patch set 1 V +1 01/18/21, 09:54 Completed build in 22m 25s on Mon, 18 Jan, 09:54 AM Test Summary: 32589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8903

  5. Oli Bartsch uploaded patch set 2 01/19/21, 15:43

  6. TYPO3com voted on patch set 2 V -1 01/19/21, 15:53 Completed build in 09m 53s on Tue, 19 Jan, 03:53 PM Test Summary: 2 of 32457 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8918

  7. TYPO3com commented on patch set 2 01/19/21, 16:05 Completed build in 31m 33s on Tue, 19 Jan, 04:05 PM Test Summary: 1 of 32836 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8918

  8. TYPO3com commented on patch set 2 01/19/21, 16:23 Completed build in 1h 11m 10s on Tue, 19 Jan, 04:23 PM Test Summary: 1 of 32836 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8918

  9. TYPO3com voted on patch set 2 V +1 01/19/21, 16:36 Completed build in 2h 04m 02s on Tue, 19 Jan, 04:36 PM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8918

  10. Richard Haeser voted on patch set 2 V +1 CR +1 01/20/21, 20:06

  11. Benni Mack voted on patch set 2 V +2 CR +2 01/20/21, 21:10

  12. Benni Mack merged patch set 3 01/20/21, 21:10