Review main Merged

67461[BUGFIX] Streamline checkbox rendering in TYPO3 Backend

Benni Mack CR +2 V +2 Hard +276 −326 updated 01/19/21, 16:45

Commit message

This change uses Twitter Bootstrap 5 usages across TYPO3 Backend,
and fixes the toggle / icon toggle switch.

Now the bootstrap-5 based toggle (form-switch) is used,
and can be modified easily with a custom SVG later-on, but is
kept as is for now, in order to make sure it is used consistently
everywhere.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 40

Show 20 more files

Review log 1318

  1. Benni Mack uploaded patch set 1 01/18/21, 13:29

  2. Benni Mack uploaded patch set 2 01/18/21, 13:45

  3. Benni Mack uploaded patch set 3 01/19/21, 08:30

  4. TYPO3com voted on patch set 3 V +1 01/19/21, 08:39 Completed build in 09m 14s on Tue, 19 Jan, 08:39 AM Test Summary: 32589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8911

  5. Benni Mack uploaded patch set 4 01/19/21, 10:54

  6. TYPO3com voted on patch set 4 V +1 01/19/21, 11:04 Completed build in 09m 32s on Tue, 19 Jan, 11:04 AM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8913

  7. Richard Haeser voted on patch set 4 V +1 CR +1 01/19/21, 12:08

  8. Oli Bartsch commented on patch set 4 CR -1 01/19/21, 13:52

    On it.
  9. Oli Bartsch uploaded patch set 5 01/19/21, 15:07

  10. TYPO3com voted on patch set 5 V -1 01/19/21, 15:17 Completed build in 10m 04s on Tue, 19 Jan, 03:17 PM Test Summary: 1 of 32836 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8916

  11. TYPO3com voted on patch set 5 V +1 01/19/21, 15:27 Completed build in 30m 04s on Tue, 19 Jan, 03:27 PM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8916

  12. Oli Bartsch voted on patch set 5 V +1 CR +1 01/19/21, 15:36

  13. Oli Bartsch commented on patch set 6 01/19/21, 15:54

    Published edit on patch set 5.
  14. Oli Bartsch commented on patch set 6 V +1 CR +1 01/19/21, 15:55

    Just removed a leftover empty label tag.
  15. TYPO3com voted on patch set 6 V +1 01/19/21, 16:05 Completed build in 11m 11s on Tue, 19 Jan, 04:05 PM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8919

  16. Benni Mack commented on patch set 6 01/19/21, 16:25

    Reply

    that was left on purpose to keep the height, but in this case, it does not matter.
  17. Oliver Hader voted on patch set 6 V +2 CR +2 01/19/21, 16:44

  18. Oliver Hader merged patch set 7 01/19/21, 16:45