67461[BUGFIX] Streamline checkbox rendering in TYPO3 Backend
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 40
- Build/Sources/Sass/component/_checkbox.scss+74 −139
- Build/Sources/Sass/variables/_main.scss+1 −0
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/CheckboxElement.php+5 −5
- typo3/sysext/backend/Classes/Form/Element/CheckboxLabeledToggleElement.php+7 −7
- typo3/sysext/backend/Classes/Form/Element/CheckboxToggleElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/InputColorPickerElement.php+8 −8
- typo3/sysext/backend/Classes/Form/Element/InputDateTimeElement.php+8 −8
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+8 −8
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+8 −8
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+8 −8
- typo3/sysext/backend/Classes/Form/Element/UserSysFileStorageIsPublicElement.php+4 −4
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ContentElement/MoveElement.html+4 −4
- typo3/sysext/backend/Resources/Private/Templates/Page/NewPages.html+9 −9
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/core/Classes/Database/QueryGenerator.php+8 −6
- typo3/sysext/core/Classes/ViewHelpers/Form/TypoScriptConstantsViewHelper.php+2 −1
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/UnresolvedDependenciesMessage.html+4 −3
- typo3/sysext/extensionmanager/Resources/Private/Templates/UploadExtensionFile/Form.html+3 −3
Show 20 more files
- typo3/sysext/filelist/Classes/Controller/File/FileUploadController.php+3 −3
- typo3/sysext/filelist/Resources/Private/Partials/ListOptions.html+9 −9
- typo3/sysext/filelist/Resources/Private/Templates/File/ReplaceFile.html+4 −2
- typo3/sysext/impexp/Resources/Private/Partials/Export/Configuration.html+12 −8
- typo3/sysext/info/Resources/Private/Partials/PageTsConfig/Menu.html+3 −3
- typo3/sysext/install/Resources/Private/Partials/Settings/LocalConfiguration/SubSection.html+11 −9
- typo3/sysext/install/Resources/Private/Templates/Maintenance/CreateAdmin.html+7 −7
- typo3/sysext/install/Resources/Private/Templates/Settings/FeaturesGetContent.html+4 −4
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTaskAdditionalFieldProvider.php+4 −4
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+5 −5
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+6 −8
- typo3/sysext/lowlevel/Resources/Private/Templates/Backend/Configuration.html+11 −11
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php+4 −3
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+4 −4
- typo3/sysext/recordlist/Classes/View/FolderUtilityRenderer.php+3 −3
- typo3/sysext/recordlist/Resources/Private/Templates/FieldSelectBox.html+7 −5
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionAdditionalFieldProvider.php+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+3 −2
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateAnalyzerModuleFunction.html+3 −3
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateObjectBrowserModuleFunction.html+4 −4
Review log 1318
-
Benni Mack uploaded patch set 1 01/18/21, 13:29
-
Benni Mack uploaded patch set 2 01/18/21, 13:45
-
Benni Mack uploaded patch set 3 01/19/21, 08:30
-
TYPO3com voted on patch set 3 V +1 01/19/21, 08:39 Completed build in 09m 14s on Tue, 19 Jan, 08:39 AM Test Summary: 32589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8911
-
Benni Mack uploaded patch set 4 01/19/21, 10:54
-
TYPO3com voted on patch set 4 V +1 01/19/21, 11:04 Completed build in 09m 32s on Tue, 19 Jan, 11:04 AM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8913
-
Richard Haeser voted on patch set 4 V +1 CR +1 01/19/21, 12:08
-
Oli Bartsch commented on patch set 4 CR -1 01/19/21, 13:52
On it. -
Oli Bartsch uploaded patch set 5 01/19/21, 15:07
-
TYPO3com voted on patch set 5 V -1 01/19/21, 15:17 Completed build in 10m 04s on Tue, 19 Jan, 03:17 PM Test Summary: 1 of 32836 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8916
-
TYPO3com voted on patch set 5 V +1 01/19/21, 15:27 Completed build in 30m 04s on Tue, 19 Jan, 03:27 PM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8916
-
Oli Bartsch voted on patch set 5 V +1 CR +1 01/19/21, 15:36
-
Oli Bartsch commented on patch set 6 01/19/21, 15:54
Published edit on patch set 5. -
Oli Bartsch commented on patch set 6 V +1 CR +1 01/19/21, 15:55
Just removed a leftover empty label tag. -
TYPO3com voted on patch set 6 V +1 01/19/21, 16:05 Completed build in 11m 11s on Tue, 19 Jan, 04:05 PM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8919
-
Benni Mack commented on patch set 6 01/19/21, 16:25
Reply
that was left on purpose to keep the height, but in this case, it does not matter. -
Oliver Hader voted on patch set 6 V +2 CR +2 01/19/21, 16:44
-
Oliver Hader merged patch set 7 01/19/21, 16:45