67465[TASK] Migrate topbar scaffolding to flexbox
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 9
- Build/Sources/Sass/scaffold/_modulemenu.scss+6 −2
- Build/Sources/Sass/scaffold/_scaffold.scss3+22 −14
- Build/Sources/Sass/scaffold/_toolbar.scss+28 −26
- Build/Sources/Sass/scaffold/_topbar.scss+9 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport.ts+0 −1
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/LiveSearchToolbarItem.html+8 −10
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport.js+1 −1
Review log 2333
Show 58 earlier messages
-
Benni Mack uploaded patch set 1 01/19/21, 16:10
-
Benni Mack uploaded patch set 2 01/19/21, 16:48
-
TYPO3com voted on patch set 2 V +1 01/19/21, 16:59 Completed build in 10m 30s on Tue, 19 Jan, 04:59 PM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8921
-
Benni Mack uploaded patch set 3 01/20/21, 06:08
-
TYPO3com voted on patch set 3 V +1 01/20/21, 06:17 Completed build in 09m 07s on Wed, 20 Jan, 06:17 AM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8928
-
Benni Mack uploaded patch set 4 01/20/21, 07:41
-
TYPO3com voted on patch set 4 V +1 01/20/21, 07:51 Completed build in 09m 07s on Wed, 20 Jan, 07:51 AM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8929
-
Benni Mack uploaded patch set 5 01/20/21, 08:00
-
TYPO3com voted on patch set 5 V +1 01/20/21, 08:10 Completed build in 08m 55s on Wed, 20 Jan, 08:10 AM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8930
-
Benjamin Franzke commented on patch set 5 01/20/21, 08:34
-
Benni Mack commented on patch set 5 01/20/21, 09:19
_scaffold.scss:73Replyagreed. flex-grow: 1 is fine. -
Benjamin Franzke commented on patch set 5 V -1 01/20/21, 09:22
ul.toolbar-list is cropped, when expanded in mobile view: https://bnf.dev/~ben/uploads/2384c/typo3-67465-5-cropped-toolbar-list.png -
Benjamin Franzke uploaded patch set 6 01/20/21, 09:53
-
TYPO3com voted on patch set 6 V +1 01/20/21, 10:02 Completed build in 09m 24s on Wed, 20 Jan, 10:02 AM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8933
-
Benjamin Franzke commented on patch set 6 01/20/21, 10:10
_scaffold.scss:73ReplyDone -
Richard Haeser commented on patch set 6 01/20/21, 15:23
When typing in the searchbox, I get an additional (blue) cross to remove the typed value. -
Richard Haeser commented on patch set 6 01/20/21, 15:25
-
Benni Mack uploaded patch set 7 01/21/21, 06:31
-
TYPO3com voted on patch set 7 V +1 01/21/21, 06:41 Completed build in 10m 16s on Thu, 21 Jan, 06:41 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8950
-
Benni Mack commented on patch set 7 01/21/21, 08:09
Reply
Fixed! -
Richard Haeser voted on patch set 7 V +1 CR +1 01/21/21, 08:17
-
Benjamin Franzke uploaded patch set 8 01/21/21, 08:20
-
Benjamin Franzke commented on patch set 8 V -1 01/21/21, 08:27
Fixed a horizontal scrollbar in mobile toolbar search results in patchset 8. Though, this is still not ready. I will only have time as of this evening, so if anyone wants to pick up earlier, here are the remaining glitches I found: * mobile: Help module name not readable (they names are hidden, only the icons appear) * when switching from mobile view, with a *opened* toolbar menu, to desktop mode (e.g. by resizing browser or rotating tablet), the tooblar is shown below the header topbar instead of next to it: https://bnf.dev/~ben/uploads/e7f6f/typo3-67465-8-toolbar-state-after-mobile-to-desktop-switch.png -
TYPO3com voted on patch set 8 V -1 01/21/21, 08:32 Completed build in 11m 51s on Thu, 21 Jan, 08:32 AM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8952
-
TYPO3com voted on patch set 8 V +1 01/21/21, 09:01 Completed build in 51m 13s on Thu, 21 Jan, 09:00 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8952
-
Benni Mack uploaded patch set 9 01/21/21, 20:19
-
Benni Mack commented on patch set 9 01/21/21, 20:20
Reply
I fixed both. Happy if you could review my code changes of the latest patch set. -
TYPO3com voted on patch set 9 V +1 01/21/21, 20:31 Completed build in 11m 56s on Thu, 21 Jan, 08:31 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8971
-
Benjamin Franzke uploaded patch set 10 01/22/21, 07:37
Rebased on master -
TYPO3com voted on patch set 10 V +1 01/22/21, 07:47 Completed build in 09m 49s on Fri, 22 Jan, 07:47 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8978
-
Oli Bartsch voted on patch set 10 V +1 CR +1 01/22/21, 08:49
-
Benni Mack voted on patch set 10 V +2 CR +2 01/22/21, 08:49
-
Benni Mack merged patch set 11 01/22/21, 08:49
_scaffold.scss:73