67467[TASK] Organize file / link selector output
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Oli Bartsch +1
-
Verified V +2 Done
- Richard Haeser +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Controller/File/FileController.php+4 −3
- typo3/sysext/filelist/Resources/Private/Templates/File/CreateFolder.html+1 −1
- typo3/sysext/recordlist/Classes/Browser/FileBrowser.php4+16 −42
- typo3/sysext/recordlist/Classes/View/FolderUtilityRenderer.php+69 −84
- typo3/sysext/recordlist/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/recordlist/Resources/Private/Language/locallang_browse_links.xlf+3 −0
- typo3/sysext/recordlist/Resources/Private/Templates/LinkBrowser/File.html+12 −10
- typo3/sysext/recordlist/Resources/Private/Templates/LinkBrowser/Mail.html+2 −2
- typo3/sysext/recordlist/Resources/Private/Templates/LinkBrowser/Telephone.html+2 −2
- typo3/sysext/recordlist/Resources/Private/Templates/LinkBrowser/Url.html+2 −2
Review log 1117
-
Benni Mack uploaded patch set 1 01/19/21, 16:52
-
TYPO3com voted on patch set 1 V +1 01/19/21, 17:04 Completed build in 12m 18s on Tue, 19 Jan, 05:04 PM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8922
-
Benni Mack uploaded patch set 2 01/19/21, 20:56
-
TYPO3com voted on patch set 2 V -1 01/19/21, 21:08 Completed build in 11m 57s on Tue, 19 Jan, 09:08 PM Test Summary: 1 of 32475 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8924
-
Benni Mack uploaded patch set 3 01/20/21, 06:02
-
TYPO3com voted on patch set 3 V +1 01/20/21, 06:11 Completed build in 09m 23s on Wed, 20 Jan, 06:11 AM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8927
-
Richard Haeser commented on patch set 3 CR -1 01/21/21, 10:28
On itFileBrowser.php:239The input of $lang->sL should be prepended with LLL:FileBrowser.php:240By this early return, you also have no visual feedback which folder is selected at the moment. Normally the foldername is mentioned in the table header, but as the table is not rendered anymore when no files are available you don't have that info now anymore. I think it would be better to have the selected folder visual in the tree, but that might be a bigger change. Maybe we should just mention the folder name in the message. -
Richard Haeser uploaded patch set 4 01/21/21, 10:29
-
Richard Haeser voted on patch set 4 V +1 CR +1 01/21/21, 10:32
-
TYPO3com voted on patch set 4 V +1 01/21/21, 10:39 Completed build in 10m 36s on Thu, 21 Jan, 10:39 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8953
-
Richard Haeser commented on patch set 4 01/21/21, 10:49
FileBrowser.php:239ReplyDoneFileBrowser.php:240ReplyDone -
Oli Bartsch uploaded patch set 5 01/21/21, 11:29
-
Oli Bartsch voted on patch set 5 V +1 CR +1 01/21/21, 11:29
-
TYPO3com voted on patch set 5 V -1 01/21/21, 11:41 Completed build in 11m 50s on Thu, 21 Jan, 11:41 AM Test Summary: 31857 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8959
-
TYPO3com voted on patch set 5 V +1 01/21/21, 11:50 Completed build in 32m 59s on Thu, 21 Jan, 11:50 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8959
-
Richard Haeser voted on patch set 5 V +2 CR +2 01/21/21, 12:22
-
Richard Haeser merged patch set 6 01/21/21, 12:22