Review main Merged

67468[BUGFIX] Use correct data attribute in constant editor

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 01/20/21, 15:13

Commit message

In the bootstrap v5 migration the data attribute key which is used
in JavaScript to perform actions depending on the toggle state,
has changed. Now the correct data attribute key is used again.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Oli Bartsch uploaded patch set 1 01/19/21, 21:39

  2. Benni Mack voted on patch set 1 V +1 CR +1 01/19/21, 21:46

  3. TYPO3com voted on patch set 1 V -1 01/19/21, 21:51 Completed build in 11m 46s on Tue, 19 Jan, 09:51 PM Test Summary: 1 of 29645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8926

  4. TYPO3com voted on patch set 1 V +1 01/19/21, 22:03 Completed build in 34m 39s on Tue, 19 Jan, 10:02 PM Test Summary: 32595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8926

  5. Richard Haeser voted on patch set 1 V +2 CR +2 01/20/21, 15:13

  6. Richard Haeser merged patch set 2 01/20/21, 15:13