Review main Merged

67469[TASK] Migrate to D3.js v6

Benjamin Franzke CR +2 V +2 Hard +270 −368 updated 02/01/21, 19:50

Commit message

D3.js v6 contains quite some changes, but most
are irrelevant for TYPO3, as we already migrated
from d3-request to core AjaxRequest in #93186.
That means we only need to adapt for the global
d3-event removal.

Commands used:
  yarn add d3@^6.3.1
  grunt build

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 2

Files 8

Review log 1420

  1. Benjamin Franzke uploaded patch set 1 01/20/21, 08:13

  2. TYPO3com voted on patch set 1 V -1 01/20/21, 08:22 Completed build in 08m 46s on Wed, 20 Jan, 08:22 AM Test Summary: 37 of 32836 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8931

  3. Benni Mack uploaded patch set 2 02/01/21, 12:36

  4. TYPO3com voted on patch set 2 V -1 02/01/21, 12:46 Completed build in 09m 37s on Mon, 1 Feb, 12:46 PM Test Summary: 35 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9138

  5. Benni Mack uploaded patch set 3 02/01/21, 13:22

  6. TYPO3com voted on patch set 3 V -1 02/01/21, 13:32 Completed build in 10m 01s on Mon, 1 Feb, 01:32 PM Test Summary: 5 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9140

  7. Benni Mack uploaded patch set 4 02/01/21, 13:52

  8. Benni Mack marked it ready for review 02/01/21, 13:54

  9. TYPO3com voted on patch set 4 V +1 02/01/21, 14:03 Completed build in 10m 14s on Mon, 1 Feb, 02:03 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9142

  10. Benni Mack updated the commit message in patch set 5 02/01/21, 14:21

  11. Richard Haeser commented on patch set 5 V +1 02/01/21, 14:27

    Didn't find any issues while using the new version of D3.js
  12. Richard Haeser voted on patch set 5 CR +1 02/01/21, 14:29

  13. TYPO3com voted on patch set 5 V +1 02/01/21, 14:31 Completed build in 09m 32s on Mon, 1 Feb, 02:31 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9147

  14. Benjamin Franzke updated the commit message in patch set 6 02/01/21, 14:32

  15. Benjamin Franzke voted on patch set 6 V +1 CR +1 02/01/21, 14:38

  16. Richard Haeser voted on patch set 6 V +1 CR +1 02/01/21, 14:40

  17. TYPO3com voted on patch set 6 V +1 02/01/21, 14:47 Completed build in 13m 26s on Mon, 1 Feb, 02:47 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9151

  18. Benni Mack voted on patch set 6 V +2 CR +2 02/01/21, 14:57

  19. Benni Mack merged patch set 7 02/01/21, 14:57

  20. Benjamin Franzke commented on patch set 7 02/01/21, 19:50