Review 10.4 Merged

67475[BUGFIX] Properly show unchanged workspace records in workspace module

Benni Mack CR +2 V +2 Normal +55 −15 updated 01/22/21, 20:04

Commit message

When a user is editing a complex data structure with IRRE and
if he just changes one entry of a structure then
all the items will be shown as changed in the workspace module.
Most users will wonder why an element is shown as changed even
if the user didn't touch this particular entry.

This change will hide the "show differences" button in the module
for entries where no data was changed except for internal properties.

Those items will also have a different color in the list. Now the user
can easily identify the records where something was really
changed and open the diff to see what has changed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 57

  1. Benni Mack commented on patch set 1 01/19/21, 08:10

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/workspaces/Resources/Public/TypeScript/Backend.ts * typo3/sysext/backend/Resources/Public/Css/backend.css * typo3/sysext/workspaces/Resources/Public/JavaScript/Backend.js
  2. Benni Mack uploaded patch set 2 01/19/21, 08:17

  3. Benni Mack marked it ready for review 01/19/21, 08:17

  4. TYPO3com voted on patch set 1 V -1 01/19/21, 08:22 Completed build in 11m 37s on Tue, 19 Jan, 08:22 AM Test Summary: 30 of 75829 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-993

  5. TYPO3com voted on patch set 2 V +1 01/19/21, 08:29 Completed build in 11m 14s on Tue, 19 Jan, 08:29 AM Test Summary: 75344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-994

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/22/21, 20:04

  7. Benni Mack merged patch set 3 01/22/21, 20:04