Review 10.4 Merged

67476[BUGFIX] Don't render hreflang tag for pages with canonical set

Richard Haeser CR +2 V +2 Normal +97 −2 updated 01/20/21, 19:39

Commit message

When a canonical link is set in the page properties, this page
or translation should not get a hreflang link in frontend as this
might send conflicting signals to search engines.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 69

  1. Richard Haeser commented on patch set 1 01/20/21, 15:34

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/seo/Classes/HrefLang/HrefLangGenerator.php * typo3/sysext/seo/Tests/Functional/Fixtures/HrefLangScenario.yml * typo3/sysext/seo/Tests/Functional/HrefLang/HrefLangGeneratorTest.php
  2. TYPO3com voted on patch set 1 V -1 01/20/21, 15:34 Completed build in 19s on Wed, 20 Jan, 03:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-996

  3. Richard Haeser uploaded patch set 2 01/20/21, 16:02

  4. TYPO3com voted on patch set 2 V -1 01/20/21, 16:13 Completed build in 11m 22s on Wed, 20 Jan, 04:13 PM Test Summary: 12 of 75841 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-997

  5. Richard Haeser uploaded patch set 3 01/20/21, 19:25

  6. Richard Haeser commented on patch set 3 01/20/21, 19:30

    This change is ready for review.
  7. TYPO3com voted on patch set 3 V +1 01/20/21, 19:36 Completed build in 10m 46s on Wed, 20 Jan, 07:36 PM Test Summary: 75356 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-998

  8. Richard Haeser voted on patch set 3 V +2 CR +2 01/20/21, 19:39

  9. Richard Haeser merged patch set 4 01/20/21, 19:39