Review main Merged

67492[BUGFIX] Never fetch content with delete placeholder

Oli Bartsch CR +2 V +2 Easy +3 −10 updated 02/11/21, 13:34

Commit message

The content fetcher did not consider delete placeholders.
This task was done using a method in GridColumnItem which
was used in the templates directly. Because defLangBinding
is more complex, three additional calls to this method would
be needed.

Since such records shouldn't even be passed to the view at all,
this check is now directly added into the content fetcher. This
means that no elements with a delete placeholder are fetched
anymore, making the getter and the calls in the templates
superfluous. Therefore, the getter along with its single usage
is removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 711

  1. Oli Bartsch uploaded patch set 1 01/20/21, 16:07

  2. TYPO3com voted on patch set 1 V -1 01/20/21, 16:11 Completed build in 23s on Wed, 20 Jan, 04:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8939

  3. Oli Bartsch uploaded patch set 2 01/20/21, 16:16

  4. TYPO3com voted on patch set 2 V +1 01/20/21, 16:25 Completed build in 09m 09s on Wed, 20 Jan, 04:25 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8940

  5. Oli Bartsch rebased onto patch set 3 02/10/21, 22:39

  6. TYPO3com voted on patch set 3 V +1 02/10/21, 22:46 Completed build in 07m 27s on Wed, 10 Feb, 10:46 PM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9454

  7. core-ci voted on patch set 3 V +1 02/10/21, 22:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/617

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 02/11/21, 10:39

  9. Jochen Roth voted on patch set 3 V +1 CR +1 02/11/21, 13:14

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 02/11/21, 13:34

  11. Christian Kuhn merged patch set 4 02/11/21, 13:34