Review main Merged

67494[TASK] Improved record history view

Benni Mack CR +2 V +2 Hard +141 −214 updated 01/25/21, 20:37

Commit message

The Record History module has been revamped:

* The settings are now placed as inline-form, using less space
* Several "buttons" are moved to the docheader, using less space
* A proper wrap around the differences is added (thanks to Nicole Cordes for the suggestion)
* PHP-API - Settings are now using "getModuleData()" and "setModuleData()"
* Table items for each history item are now vertically-centered
* All inline stylings have been replaced by custom CSS or CSS utility classes
* Labels are streamlined

As a next step, the rollback view needs improvements, but is tackled
separately.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 2131

Show 36 earlier messages
  1. Benni Mack uploaded patch set 1 01/21/21, 10:48

  2. Benni Mack uploaded patch set 2 01/21/21, 11:04

  3. TYPO3com voted on patch set 1 V -1 01/21/21, 11:10 Completed build in 22m 09s on Thu, 21 Jan, 11:10 AM Test Summary: 31134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8955

  4. TYPO3com voted on patch set 2 V -1 01/21/21, 11:17 Completed build in 11m 16s on Thu, 21 Jan, 11:17 AM Test Summary: 28491 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8958

  5. Benni Mack uploaded patch set 3 01/21/21, 12:22

  6. TYPO3com voted on patch set 3 V -1 01/21/21, 12:33 Completed build in 10m 35s on Thu, 21 Jan, 12:33 PM Test Summary: 32592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8961

  1. TYPO3com voted on patch set 3 V +1 01/21/21, 15:26 Completed build in 10m 31s on Thu, 21 Jan, 03:26 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8967

  2. Benni Mack commented on patch set 3 01/21/21, 15:45

    When using the filter, existing GET parameters are lost.
  3. Benni Mack voted on patch set 3 V -1 01/21/21, 15:45

  4. Benni Mack uploaded patch set 4 01/21/21, 17:06

  5. TYPO3com voted on patch set 4 V +1 01/21/21, 17:15 Completed build in 08m 50s on Thu, 21 Jan, 05:15 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8969

  6. Richard Haeser voted on patch set 4 V +1 CR +1 01/21/21, 19:32

  7. Benni Mack uploaded patch set 5 01/21/21, 21:13

  8. Richard Haeser voted on patch set 5 V +1 CR +1 01/21/21, 21:14

  9. TYPO3com voted on patch set 5 V +1 01/21/21, 21:24 Completed build in 10m 22s on Thu, 21 Jan, 09:24 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8976

  10. Benni Mack uploaded patch set 6 01/22/21, 08:53

  11. TYPO3com voted on patch set 6 V +1 01/22/21, 09:02 Completed build in 09m 08s on Fri, 22 Jan, 09:02 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8982

  12. Benni Mack uploaded patch set 7 01/25/21, 07:32

  13. TYPO3com voted on patch set 7 V +1 01/25/21, 07:43 Completed build in 10m 23s on Mon, 25 Jan, 07:43 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9030

  14. Benni Mack uploaded patch set 8 01/25/21, 11:00

  15. Oliver Hader commented on patch set 8 01/25/21, 11:08

    History.html:6 Unresolved

    I'd opt to get it top-aligned...

    History.html:36 Unresolved

    I'd opt for allowing text wrapping here for longer usernames like `oliver.hader.admin`

    History.html:78

    Is f:format.raw() really required here?
  16. TYPO3com voted on patch set 8 V +1 01/25/21, 11:11 Completed build in 10m 55s on Mon, 25 Jan, 11:11 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9033

  17. Oliver Hader commented on patch set 8 01/25/21, 11:11

    History.html:78 Reply

    I see... the label does contain markup
  18. Oliver Hader commented on patch set 8 01/25/21, 11:25

    _diff.scss:73 Unresolved

    This renders the whole block with the background color now... Please see screenshot at https://forge.typo3.org/issues/93330#note-11
  19. Oliver Hader commented on patch set 8 01/25/21, 11:26

    History.html:78 Reply

    Done
  20. Nicole Hummel voted on patch set 8 V +1 CR +1 01/25/21, 11:36

  21. Benni Mack uploaded patch set 9 01/25/21, 16:58

  22. TYPO3com voted on patch set 9 V +1 01/25/21, 17:08 Completed build in 10m 00s on Mon, 25 Jan, 05:08 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9044

  23. Oliver Hader commented on patch set 9 V +1 CR +1 01/25/21, 18:29

    Change is fine in general - I'll leave it to you whether styling remarks are considered now or in a later step.
  24. Georg Ringer voted on patch set 9 V +2 CR +2 01/25/21, 20:37

  25. Georg Ringer merged patch set 10 01/25/21, 20:37