67494[TASK] Improved record history view
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Hader +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Hader +1
- TYPO3com +1 CI
Issues 1
Files 11
- Build/Sources/Sass/component/_diff.scss1+4 −2
- Build/Sources/Sass/typo3/_history.scssnew+12 −0
- Build/Sources/Sass/backend.scss+1 −0
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+63 −112
- typo3/sysext/backend/Resources/Private/Language/locallang_show_rechis.xlf+4 −7
- typo3/sysext/backend/Resources/Private/Partials/RecordHistory/Diff.html+1 −1
- typo3/sysext/backend/Resources/Private/Partials/RecordHistory/History.html5+10 −10
- typo3/sysext/backend/Resources/Private/Partials/RecordHistory/MultipleDiff.html+9 −11
- typo3/sysext/backend/Resources/Private/Partials/RecordHistory/Settings.html+32 −69
- typo3/sysext/backend/Resources/Private/Templates/RecordHistory/Main.html+4 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
Review log 2131
Show 36 earlier messages
-
Benni Mack uploaded patch set 1 01/21/21, 10:48
-
Benni Mack uploaded patch set 2 01/21/21, 11:04
-
TYPO3com voted on patch set 1 V -1 01/21/21, 11:10 Completed build in 22m 09s on Thu, 21 Jan, 11:10 AM Test Summary: 31134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8955
-
TYPO3com voted on patch set 2 V -1 01/21/21, 11:17 Completed build in 11m 16s on Thu, 21 Jan, 11:17 AM Test Summary: 28491 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8958
-
Benni Mack uploaded patch set 3 01/21/21, 12:22
-
TYPO3com voted on patch set 3 V -1 01/21/21, 12:33 Completed build in 10m 35s on Thu, 21 Jan, 12:33 PM Test Summary: 32592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8961
-
TYPO3com voted on patch set 3 V +1 01/21/21, 15:26 Completed build in 10m 31s on Thu, 21 Jan, 03:26 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8967
-
Benni Mack commented on patch set 3 01/21/21, 15:45
When using the filter, existing GET parameters are lost. -
Benni Mack voted on patch set 3 V -1 01/21/21, 15:45
-
Benni Mack uploaded patch set 4 01/21/21, 17:06
-
TYPO3com voted on patch set 4 V +1 01/21/21, 17:15 Completed build in 08m 50s on Thu, 21 Jan, 05:15 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8969
-
Richard Haeser voted on patch set 4 V +1 CR +1 01/21/21, 19:32
-
Benni Mack uploaded patch set 5 01/21/21, 21:13
-
Richard Haeser voted on patch set 5 V +1 CR +1 01/21/21, 21:14
-
TYPO3com voted on patch set 5 V +1 01/21/21, 21:24 Completed build in 10m 22s on Thu, 21 Jan, 09:24 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8976
-
Benni Mack uploaded patch set 6 01/22/21, 08:53
-
TYPO3com voted on patch set 6 V +1 01/22/21, 09:02 Completed build in 09m 08s on Fri, 22 Jan, 09:02 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8982
-
Benni Mack uploaded patch set 7 01/25/21, 07:32
-
TYPO3com voted on patch set 7 V +1 01/25/21, 07:43 Completed build in 10m 23s on Mon, 25 Jan, 07:43 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9030
-
Benni Mack uploaded patch set 8 01/25/21, 11:00
-
Oliver Hader commented on patch set 8 01/25/21, 11:08
History.html:6UnresolvedI'd opt to get it top-aligned...History.html:36UnresolvedI'd opt for allowing text wrapping here for longer usernames like `oliver.hader.admin`History.html:78Is f:format.raw() really required here? -
TYPO3com voted on patch set 8 V +1 01/25/21, 11:11 Completed build in 10m 55s on Mon, 25 Jan, 11:11 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9033
-
Oliver Hader commented on patch set 8 01/25/21, 11:11
History.html:78ReplyI see... the label does contain markup -
Oliver Hader commented on patch set 8 01/25/21, 11:25
_diff.scss:73UnresolvedThis renders the whole block with the background color now... Please see screenshot at https://forge.typo3.org/issues/93330#note-11 -
Oliver Hader commented on patch set 8 01/25/21, 11:26
History.html:78ReplyDone -
Nicole Hummel voted on patch set 8 V +1 CR +1 01/25/21, 11:36
-
Benni Mack uploaded patch set 9 01/25/21, 16:58
-
TYPO3com voted on patch set 9 V +1 01/25/21, 17:08 Completed build in 10m 00s on Mon, 25 Jan, 05:08 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9044
-
Oliver Hader commented on patch set 9 V +1 CR +1 01/25/21, 18:29
Change is fine in general - I'll leave it to you whether styling remarks are considered now or in a later step. -
Georg Ringer voted on patch set 9 V +2 CR +2 01/25/21, 20:37
-
Georg Ringer merged patch set 10 01/25/21, 20:37