Review main Merged

67498[BUGFIX] Fix redirects to access restricted pages

Oli Bartsch CR +2 V +2 Normal +143 −0 updated 02/10/21, 10:12

Commit message

The RedirectService is using typolink to build links
to the defined target, e.g. a page. In case the redirect
target is an access restricted page and the user is
unauthorized, typolink did not build this link and
therefore the request resulted in a 404 response.

Since unauthorized requests to an access restricted
page should always return a 403 status code, the
`linkAccessRestrictedPages` option is now set in the
typolink configuration. Therefore, the link will be built
even if the user is unauthorized and then redirects to
the target page where the correct 403 status code is
returned.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1014

  1. Oli Bartsch uploaded patch set 1 01/21/21, 16:27

  2. TYPO3com voted on patch set 1 V +1 01/21/21, 16:37 Completed build in 09m 40s on Thu, 21 Jan, 04:37 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8968

  3. Oli Bartsch commented on patch set 1 CR -1 01/21/21, 19:04

    Will provide some test for this.
  4. Oli Bartsch uploaded patch set 2 01/21/21, 20:17

  5. TYPO3com voted on patch set 2 V +1 01/21/21, 20:27 Completed build in 10m 08s on Thu, 21 Jan, 08:27 PM Test Summary: 32604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8970

  6. Oli Bartsch uploaded patch set 3 01/22/21, 08:32

  7. Oli Bartsch uploaded patch set 4 01/22/21, 08:35

  8. TYPO3com voted on patch set 3 V -1 01/22/21, 08:44 Completed build in 11m 58s on Fri, 22 Jan, 08:44 AM Test Summary: 3 of 32845 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8980

  9. TYPO3com voted on patch set 4 V +1 01/22/21, 08:49 Completed build in 13m 59s on Fri, 22 Jan, 08:49 AM Test Summary: 32604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8981

  10. Markus Klein voted on patch set 4 CR +1 02/02/21, 11:29

  11. Richard Haeser voted on patch set 4 V +1 CR +1 02/02/21, 13:23

  12. Benjamin Franzke voted on patch set 4 CR +1 02/10/21, 10:08

  13. Benjamin Franzke voted on patch set 4 V +2 CR +2 02/10/21, 10:12

  14. Benjamin Franzke merged patch set 5 02/10/21, 10:12