Review main Merged

67500[TASK] Simplify usage of SimplePagination

Georg Ringer CR +2 V +2 Easy +13 −0 updated 01/22/21, 18:55

Commit message

Providing the pages of a pagination directly in the `SimplePagination`
reduced the work of extension developers.
In Fluid it is now possible to iterate over all pages without the need
of providing this for every usage.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Georg Ringer uploaded patch set 1 01/21/21, 21:04

  2. Georg Ringer commented on patch set 1 01/21/21, 21:05

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 01/21/21, 21:14 Completed build in 10m 07s on Thu, 21 Jan, 09:14 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8975

  4. Wouter Wolters voted on patch set 1 CR +1 01/21/21, 21:31

  5. Oli Bartsch commented on patch set 1 01/22/21, 08:59

    SimplePagination.php:87 Unresolved

    Just to be consistent with the existing methods I would suggest to name this method: getAllPageNumbers().

    SimplePagination.php:89 Unresolved

    What do you think about using $this->getFirstPageNumber as $start Parameter?
  6. Georg Ringer uploaded patch set 2 01/22/21, 13:20

  7. TYPO3com voted on patch set 2 V +1 01/22/21, 13:31 Completed build in 10m 54s on Fri, 22 Jan, 01:31 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8986

  8. Oli Bartsch commented on patch set 2 V +1 CR +1 01/22/21, 13:38

    Thanks for the adjustments :)
  9. Benni Mack voted on patch set 2 V +2 CR +2 01/22/21, 18:55

  10. Benni Mack merged patch set 3 01/22/21, 18:55