Review main Merged

67502[TASK] Migrate backend scaffolding to flexbox

Benjamin Franzke CR +2 V +2 Hard +126 −217 updated 01/22/21, 20:38

Commit message

Use flexbox for layouting to avoid transform/position
based shifting of the content module.
Also use `position: sticky` instead of `position: fixed`,
as it allows to avoid padding hacks.

Also remove manual Viewport.doLayout() hacks, as we can
now use `width: auto` as replacement for a static
snapped-module menu width.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1323

  1. Benjamin Franzke uploaded patch set 1 01/22/21, 08:08

  2. TYPO3com voted on patch set 1 V -1 01/22/21, 08:09 Completed build in 20s on Fri, 22 Jan, 08:09 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8979

  3. Benni Mack uploaded patch set 2 01/22/21, 09:04

  4. TYPO3com commented on patch set 2 01/22/21, 09:15 Completed build in 10m 14s on Fri, 22 Jan, 09:15 AM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8983

  5. Benni Mack uploaded patch set 3 01/22/21, 15:41

  6. TYPO3com voted on patch set 3 V -1 01/22/21, 15:52 Completed build in 10m 49s on Fri, 22 Jan, 03:52 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8990

  7. Benjamin Franzke uploaded patch set 4 01/22/21, 16:03

  8. TYPO3com voted on patch set 4 V -1 01/22/21, 16:13 Completed build in 10m 39s on Fri, 22 Jan, 04:13 PM Test Summary: 8 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8991

  9. Benni Mack uploaded patch set 5 01/22/21, 16:41

  10. TYPO3com voted on patch set 5 V -1 01/22/21, 16:52 Completed build in 10m 44s on Fri, 22 Jan, 04:52 PM Test Summary: 10 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8993

  11. Benjamin Franzke uploaded patch set 6 01/22/21, 19:13

  12. TYPO3com voted on patch set 6 V -1 01/22/21, 19:25 Completed build in 11m 20s on Fri, 22 Jan, 07:25 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9001

  13. Benjamin Franzke uploaded patch set 7 01/22/21, 19:50

  14. TYPO3com voted on patch set 7 V -1 01/22/21, 20:00 Completed build in 10m 34s on Fri, 22 Jan, 08:00 PM Test Summary: 32224 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9003

  15. TYPO3com voted on patch set 7 V +1 01/22/21, 20:12 Completed build in 32m 48s on Fri, 22 Jan, 08:12 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9003

  16. Benjamin Franzke uploaded patch set 8 01/22/21, 20:19

  17. Oliver Hader commented on patch set 8 01/22/21, 20:22

    Nice!
  18. Oliver Hader voted on patch set 8 CR +1 01/22/21, 20:23

  19. TYPO3com voted on patch set 8 V -1 01/22/21, 20:29 Completed build in 09m 47s on Fri, 22 Jan, 08:29 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9004

  20. Benni Mack voted on patch set 8 V +1 CR +1 01/22/21, 20:29

  21. TYPO3com voted on patch set 8 V +1 01/22/21, 20:32 Completed build in 23m 20s on Fri, 22 Jan, 08:32 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9004

  22. Christian Kuhn voted on patch set 8 V +2 CR +2 01/22/21, 20:37

  23. Christian Kuhn merged patch set 9 01/22/21, 20:38