Review main Merged

67504[BUGFIX] Do not render empty title attributes in ImageViewHelper

Oli Bartsch CR +2 V +2 Easy +2 −1 updated 01/28/21, 18:21

Commit message

The ImageViewHelper uses strict types for checking if
the `title` property of the image is not an empty string.
Since this value can also be NULL, a typecast is necessary
for the check to work.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jochen Roth +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Oli Bartsch uploaded patch set 1 01/22/21, 11:08

  2. TYPO3com voted on patch set 1 V -1 01/22/21, 11:21 Completed build in 12m 06s on Fri, 22 Jan, 11:21 AM Test Summary: 31445 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8984

  3. TYPO3com voted on patch set 1 V +1 01/22/21, 11:32 Completed build in 35m 27s on Fri, 22 Jan, 11:32 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8984

  4. Jochen Roth voted on patch set 1 V +1 CR +1 01/25/21, 13:59

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 01/28/21, 18:21

  6. Daniel Goerz merged patch set 2 01/28/21, 18:21