Review main Merged

67505[TASK] Use buttons in Install tool

Oli Bartsch CR +2 V +2 Normal +37 −37 updated 01/25/21, 16:03

Commit message

All buttons in the install tool cards footer do now
use proper button tags instead of anchor tags with
an empty target.

Also the mark/umark buttons in "upgrade docs" do
now use proper button tags.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 913

  1. Oli Bartsch uploaded patch set 1 01/22/21, 12:36

  2. TYPO3com voted on patch set 1 V +1 01/22/21, 12:47 Completed build in 10m 43s on Fri, 22 Jan, 12:47 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8985

  3. Oli Bartsch uploaded patch set 2 01/24/21, 10:51

  4. TYPO3com voted on patch set 2 V -1 01/24/21, 11:05 Completed build in 14m 21s on Sun, 24 Jan, 11:05 AM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9020

  5. TYPO3com voted on patch set 2 V +1 01/24/21, 11:25 Completed build in 48m 43s on Sun, 24 Jan, 11:25 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9020

  6. Jochen Roth voted on patch set 2 V +1 CR +1 01/25/21, 12:01

  7. Benni Mack commented on patch set 2 01/25/21, 14:34

    Any reasons for backporting this to v10.4? This is quite complex to backport, I'd say.
  8. Oli Bartsch updated the commit message in patch set 3 01/25/21, 14:39

  9. Oli Bartsch commented on patch set 3 01/25/21, 14:42

    Reply

    You're right. Let's just do this in master.
  10. Jochen Roth voted on patch set 3 V +1 CR +1 01/25/21, 14:46

  11. TYPO3com voted on patch set 3 V +1 01/25/21, 14:49 Completed build in 09m 12s on Mon, 25 Jan, 02:49 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9043

  12. Benni Mack voted on patch set 3 V +2 CR +2 01/25/21, 16:03

  13. Benni Mack merged patch set 4 01/25/21, 16:03