67508[BUGFIX] Escape user and group name in permission module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Hader +1
- TYPO3com +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/beuser/Resources/Public/TypeScript/Permissions.ts2+48 −66
- typo3/sysext/beuser/Classes/Controller/PermissionAjaxController.php+2 −2
- typo3/sysext/beuser/Resources/Private/Partials/Permission/Groupname.html+2 −6
- typo3/sysext/beuser/Resources/Private/Partials/Permission/Ownername.html+2 −6
- typo3/sysext/beuser/Resources/Public/JavaScript/Permissions.js+1 −1
Review log 1418
-
Andreas Kienast uploaded patch set 1 01/22/21, 16:37
-
TYPO3com voted on patch set 1 V +1 01/22/21, 16:48 Completed build in 11m 22s on Fri, 22 Jan, 04:48 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8992
-
Guido Schmechel commented on patch set 1 V +1 CR +1 01/23/21, 18:03
Thx for the fast fix! -
Oli Bartsch commented on patch set 1 V -1 01/24/21, 10:37
Now "undefined" is added as label if you click on [not set] and then on "cancel". -
Andreas Kienast uploaded patch set 2 01/24/21, 10:49
-
Andreas Kienast uploaded patch set 3 01/24/21, 10:50
-
TYPO3com voted on patch set 2 V +1 01/24/21, 10:58 Completed build in 09m 11s on Sun, 24 Jan, 10:58 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9018
-
TYPO3com voted on patch set 3 V +1 01/24/21, 11:01 Completed build in 10m 31s on Sun, 24 Jan, 11:01 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9019
-
Oli Bartsch voted on patch set 3 V +1 CR +1 01/24/21, 11:21
-
Guido Schmechel voted on patch set 3 V +1 CR +1 01/24/21, 13:48
-
Oliver Hader commented on patch set 3 CR -1 01/25/21, 11:59
On it..Permissions.ts:152UnresolvedinnerText is probably enoughPermissions.ts:157Unresolvedcontainer.parentNode.replaceChild -
Oliver Hader uploaded patch set 4 01/25/21, 12:01
-
Oliver Hader voted on patch set 4 V +1 CR +1 01/25/21, 12:02
-
TYPO3com voted on patch set 4 V +1 01/25/21, 12:11 Completed build in 09m 32s on Mon, 25 Jan, 12:11 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9034
-
Oli Bartsch voted on patch set 4 V +1 CR +1 01/25/21, 12:13
-
Benni Mack voted on patch set 4 V +2 CR +2 01/25/21, 14:32
-
Benni Mack merged patch set 5 01/25/21, 14:32