Review main Merged

67508[BUGFIX] Escape user and group name in permission module

Andreas Kienast CR +2 V +2 Normal +55 −81 updated 01/25/21, 14:32

Commit message

The user name and group name are stored as data attribute in the "reset"
button in the permission module once somebody wants to change the
owner/group of a page. If the button is clicked, the stored value is
recovered.

Since the value might contains HTML entities, these values get escaped
before written back into DOM.

Additionally, the unnecessary "not set" span element has been removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1418

  1. Andreas Kienast uploaded patch set 1 01/22/21, 16:37

  2. TYPO3com voted on patch set 1 V +1 01/22/21, 16:48 Completed build in 11m 22s on Fri, 22 Jan, 04:48 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8992

  3. Guido Schmechel commented on patch set 1 V +1 CR +1 01/23/21, 18:03

    Thx for the fast fix!
  4. Oli Bartsch commented on patch set 1 V -1 01/24/21, 10:37

    Now "undefined" is added as label if you click on [not set] and then on "cancel".
  5. Andreas Kienast commented on patch set 1 CR -1 01/24/21, 10:44

    on it

    Reply

    Good catch, thanks
  6. Andreas Kienast uploaded patch set 2 01/24/21, 10:49

  7. Andreas Kienast uploaded patch set 3 01/24/21, 10:50

  8. TYPO3com voted on patch set 2 V +1 01/24/21, 10:58 Completed build in 09m 11s on Sun, 24 Jan, 10:58 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9018

  9. TYPO3com voted on patch set 3 V +1 01/24/21, 11:01 Completed build in 10m 31s on Sun, 24 Jan, 11:01 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9019

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 01/24/21, 11:21

  11. Guido Schmechel voted on patch set 3 V +1 CR +1 01/24/21, 13:48

  12. Oliver Hader commented on patch set 3 CR -1 01/25/21, 11:59

    On it..

    Permissions.ts:152 Unresolved

    innerText is probably enough

    Permissions.ts:157 Unresolved

    container.parentNode.replaceChild
  13. Oliver Hader uploaded patch set 4 01/25/21, 12:01

  14. Oliver Hader voted on patch set 4 V +1 CR +1 01/25/21, 12:02

  15. TYPO3com voted on patch set 4 V +1 01/25/21, 12:11 Completed build in 09m 32s on Mon, 25 Jan, 12:11 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9034

  16. Oli Bartsch voted on patch set 4 V +1 CR +1 01/25/21, 12:13

  17. Benni Mack voted on patch set 4 V +2 CR +2 01/25/21, 14:32

  18. Benni Mack merged patch set 5 01/25/21, 14:32