Review main Merged

67509[BUGFIX] Silently resolve invalid current page in paginator

Oli Bartsch CR +2 V +2 Normal +58 −8 updated 02/11/21, 13:32

Commit message

Passing a current page number which exceeds the maximum
number of pages to the paginator is now silently resolved
by using the last available page as the current page. This
is done to prevent empty results, since such value can be
passed unintentionally by a user. For example in case some
internal state changed after the view was initially rendered
or the view does not perform checks on this value at all.

The later will now be prevented at least in core by adding
the "max" attribute to all core paginations which previously
missed it.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 914

  1. Oli Bartsch uploaded patch set 1 01/22/21, 16:47

  2. TYPO3com voted on patch set 1 V -1 01/22/21, 17:02 Completed build in 12m 37s on Fri, 22 Jan, 05:02 PM Test Summary: 3 of 32847 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8995

  3. Oli Bartsch uploaded patch set 2 01/22/21, 17:09

  4. TYPO3com voted on patch set 2 V -1 01/22/21, 17:10 Completed build in 24s on Fri, 22 Jan, 05:10 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8998

  5. Oli Bartsch uploaded patch set 3 01/22/21, 17:21

  6. TYPO3com voted on patch set 3 V +1 01/22/21, 17:31 Completed build in 10m 13s on Fri, 22 Jan, 05:31 PM Test Summary: 32606 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8999

  7. Oli Bartsch uploaded patch set 4 01/22/21, 19:12

  8. TYPO3com voted on patch set 4 V +1 01/22/21, 19:21 Completed build in 09m 41s on Fri, 22 Jan, 07:21 PM Test Summary: 32606 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9000

  9. Oli Bartsch updated the commit message in patch set 5 02/10/21, 22:36

  10. TYPO3com voted on patch set 5 V +1 02/10/21, 22:44 Completed build in 07m 48s on Wed, 10 Feb, 10:44 PM Test Summary: 32605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9453

  11. Christian Kuhn voted on patch set 5 V +1 CR +1 02/11/21, 10:48

  12. Jochen Roth voted on patch set 5 V +1 CR +1 02/11/21, 13:26

  13. Christian Kuhn voted on patch set 5 V +2 CR +2 02/11/21, 13:31

  14. Christian Kuhn merged patch set 6 02/11/21, 13:32