Review main Merged

67510[BUGFIX] Properly position ContextMenu again

Benni Mack CR +2 V +2 Easy +12 −12 updated 02/02/21, 12:24

Commit message

With #89496 the ContextMenu got keyboard support
added. However, the underlying code does still
use only a click event to trigger the ContextMenu,
which is now also manually triggered for keypress
events. It was therefore not possible to differ
between the three possible ways, the ContextMenu
can be used:

1. Mouse click only
2. Mixed
2.1 Click on ContextMenu and navigate via keyboard
2.2 Access ContextMenu via keyboard and navigate via click
3. Keyboard only

Therefore, we now check the mouse position. If it's NULL,
the ContextMenu was openend via keyboard. Furthermore, we
use a boolean flag, which helps the getPosition method to
determine the correct position in mixed mode. Using mouse
click will now behave like before. Using the keyboard will
now always use the boundingRect for positioning.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1116

  1. Benni Mack uploaded patch set 1 01/22/21, 19:26

  2. TYPO3com voted on patch set 1 V +1 01/22/21, 19:37 Completed build in 10m 24s on Fri, 22 Jan, 07:37 PM Test Summary: 32599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9002

  3. Oliver Hader updated the commit message in patch set 2 01/25/21, 21:08

  4. TYPO3com voted on patch set 2 V -1 01/25/21, 21:20 Completed build in 11m 46s on Mon, 25 Jan, 09:20 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9049

  5. Richard Haeser commented on patch set 2 V +1 01/31/21, 09:56

    On what part do you want to work as it is marked as WIP? Do you want to enhance the code? It does fix this really annoying issue.
  6. Oli Bartsch uploaded patch set 3 02/02/21, 10:27

  7. TYPO3com voted on patch set 3 V +1 02/02/21, 10:39 Completed build in 10m 52s on Tue, 2 Feb, 10:39 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9190

  8. Richard Haeser voted on patch set 3 V +1 CR +1 02/02/21, 10:46

  9. Oli Bartsch commented on patch set 3 CR -1 02/02/21, 11:06

    ContextMenu.ts:338

    Unlikely that this method is called without having eventSources set. However, since some delay functionality is used in ContextMenu, we should ensure this by checking for this.eventSources.length.
  10. Oli Bartsch uploaded patch set 4 02/02/21, 11:07

  11. Richard Haeser voted on patch set 4 V +1 CR +1 02/02/21, 11:13

  12. TYPO3com voted on patch set 4 V -1 02/02/21, 11:18 Completed build in 10m 50s on Tue, 2 Feb, 11:18 AM Test Summary: 31533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9191

  13. TYPO3com voted on patch set 4 V +1 02/02/21, 11:24 Completed build in 27m 18s on Tue, 2 Feb, 11:24 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9191

  14. Oli Bartsch commented on patch set 4 02/02/21, 11:42

    ContextMenu.ts:338 Reply

    Done
  15. Benni Mack commented on patch set 4 V +2 CR +2 02/02/21, 12:24

    thanks!
  16. Benni Mack merged patch set 5 02/02/21, 12:24