67511[FEATURE] Enable resizing & toggling of navigation area
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Hader +1
-
Verified V +2 Done
- Georg Ringer +2
- Benjamin Franzke +1
- Oliver Hader +1
- TYPO3com +1 CI
Issues 2
Files 20
- Build/Sources/Sass/component/_svgtree.scss+1 −0
- Build/Sources/Sass/scaffold/_scaffold.scss2+97 −0
- Build/Sources/Sass/scaffold/_topbar.scss+2 −12
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Enum/Viewport/ScaffoldIdentifier.ts+2 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Enum/Viewport/TopbarIdentifiers.tsdeleted+0 −16
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/NavigationContainer.ts+47 −23
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ModuleMenu.ts+1 −6
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport.ts+70 −3
- typo3/sysext/backend/Classes/Controller/BackendController.php+0 −1
- typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php+4 −0
- typo3/sysext/backend/Resources/Private/Partials/Backend/Topbar.html+0 −1
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+9 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Enum/Viewport/ScaffoldIdentifier.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/NavigationContainer.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ModuleMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport.js+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-78760-ResizableNavigationComponent.rstnew+36 −0
- typo3/sysext/core/Resources/Private/Language/locallang_misc.xlf+6 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/NavigationComponentTreeCest.php+4 −4
Review log 3049
Show 1224 earlier messages
-
Benni Mack uploaded patch set 1 01/22/21, 22:12
-
Benni Mack updated the commit message in patch set 2 01/22/21, 22:12
-
Benni Mack updated the commit message in patch set 3 01/22/21, 22:13
-
TYPO3com voted on patch set 1 V -1 01/22/21, 22:22 Completed build in 09m 29s on Fri, 22 Jan, 10:22 PM Test Summary: 17 of 32725 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9009
-
TYPO3com voted on patch set 2 V -1 01/22/21, 22:28 Completed build in 15m 16s on Fri, 22 Jan, 10:28 PM Test Summary: 17 of 32725 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9010
-
TYPO3com voted on patch set 3 V -1 01/22/21, 22:32 Completed build in 11m 07s on Fri, 22 Jan, 10:32 PM Test Summary: 18 of 32725 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9011
-
Benni Mack uploaded patch set 4 01/22/21, 22:37
-
TYPO3com voted on patch set 4 V -1 01/22/21, 22:45 Completed build in 08m 48s on Fri, 22 Jan, 10:45 PM Test Summary: 17 of 32725 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9012
-
Benni Mack uploaded patch set 5 01/22/21, 22:58
-
TYPO3com voted on patch set 5 V -1 01/22/21, 23:06 Completed build in 08m 34s on Fri, 22 Jan, 11:06 PM Test Summary: 3 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9013
-
Benni Mack uploaded patch set 6 01/25/21, 21:40
-
TYPO3com voted on patch set 6 V -1 01/25/21, 21:52 Completed build in 11m 06s on Mon, 25 Jan, 09:52 PM Test Summary: 2 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9050
-
Benni Mack uploaded patch set 7 01/26/21, 09:02
-
TYPO3com voted on patch set 7 V -1 01/26/21, 09:11 Completed build in 09m 14s on Tue, 26 Jan, 09:11 AM Test Summary: 2 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9052
-
Benni Mack uploaded patch set 8 01/26/21, 10:58
-
Benni Mack uploaded patch set 9 01/26/21, 11:05
-
TYPO3com voted on patch set 8 V -1 01/26/21, 11:08 Completed build in 10m 16s on Tue, 26 Jan, 11:08 AM Test Summary: 2 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9056
-
TYPO3com voted on patch set 9 V -1 01/26/21, 11:14 Completed build in 09m 03s on Tue, 26 Jan, 11:14 AM Test Summary: 2 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9057
-
TYPO3com commented on patch set 9 01/26/21, 11:26 Completed build in 30m 13s on Tue, 26 Jan, 11:26 AM Test Summary: 2 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9057
-
Benni Mack uploaded patch set 10 01/26/21, 11:29
-
Benni Mack uploaded patch set 11 01/26/21, 11:36
-
TYPO3com voted on patch set 10 V -1 01/26/21, 11:41 Completed build in 12m 04s on Tue, 26 Jan, 11:41 AM Test Summary: 18 of 32725 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9058
-
TYPO3com voted on patch set 11 V -1 01/26/21, 11:48 Completed build in 11m 08s on Tue, 26 Jan, 11:48 AM Test Summary: 17 of 32725 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9059
-
Benni Mack updated the commit message in patch set 12 01/26/21, 11:53
-
TYPO3com voted on patch set 12 V -1 01/26/21, 12:03 Completed build in 09m 22s on Tue, 26 Jan, 12:03 PM Test Summary: 17 of 32725 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9061
-
Benni Mack uploaded patch set 13 01/26/21, 12:43
-
TYPO3com voted on patch set 13 V -1 01/26/21, 12:52 Completed build in 09m 04s on Tue, 26 Jan, 12:52 PM Test Summary: 18 of 32725 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9064
-
Benni Mack uploaded patch set 14 01/26/21, 14:10
-
TYPO3com voted on patch set 14 V -1 01/26/21, 14:20 Completed build in 09m 38s on Tue, 26 Jan, 02:20 PM Test Summary: 3 of 32843 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9067
-
Benni Mack uploaded patch set 15 01/26/21, 14:28
-
TYPO3com voted on patch set 15 V +1 01/26/21, 14:38 Completed build in 09m 36s on Tue, 26 Jan, 02:38 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9068
-
Oliver Hader commented on patch set 15 CR +1 01/26/21, 14:55
I'm asking myself, whether we should use e.g. hammer.js to handle tap/click events instead of using the low-level events for mouse and touch... -
Oliver Hader voted on patch set 15 V +1 CR 0 01/26/21, 14:55
-
Benni Mack uploaded patch set 16 01/26/21, 14:57
-
TYPO3com voted on patch set 16 V +1 01/26/21, 15:06 Completed build in 09m 04s on Tue, 26 Jan, 03:06 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9069
-
Oliver Hader voted on patch set 16 V +1 CR +1 01/26/21, 15:10
-
Benjamin Franzke voted on patch set 16 V +1 01/26/21, 20:25
-
Benjamin Franzke commented on patch set 16 CR -1 01/26/21, 20:38
First, partial review, posting only one remark for now… (sorry, don't have the concentration for a full review right now) Works good so far._scaffold.scss:261`flex: 0 0 1` is not a valid flex value. This does nothing (is ignored by the browser). It can be removed. If we want to be explicit, and keep a flex definition, this is either: `flex: 0 0 1px` or `flex: 0 0 auto` (auto will be resolved to the intrinsic width, which is 1px because of the explicit width attribute). I think it's fine to be explicit, so we should probably use `flex: 0 0 auto`. -
Benni Mack uploaded patch set 17 01/27/21, 07:04
-
TYPO3com voted on patch set 17 V +1 01/27/21, 07:13 Completed build in 09m 11s on Wed, 27 Jan, 07:13 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9075
-
Georg Ringer voted on patch set 17 V +1 CR +1 01/27/21, 07:25
-
Oliver Hader voted on patch set 17 CR +1 01/27/21, 08:51
-
Benni Mack uploaded patch set 18 01/27/21, 08:51
-
Oliver Hader voted on patch set 18 V +1 CR +1 01/27/21, 08:53
-
TYPO3com voted on patch set 18 V +1 01/27/21, 09:01 Completed build in 09m 50s on Wed, 27 Jan, 09:01 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9077
-
Benni Mack commented on patch set 18 01/27/21, 09:31
_scaffold.scss:261ReplyFixed! -
Benjamin Franzke voted on patch set 18 V +1 01/27/21, 09:41
-
Georg Ringer voted on patch set 18 V +2 CR +2 01/27/21, 10:00
-
Georg Ringer merged patch set 19 01/27/21, 10:01