Review main Merged

67512[DOCS] Fix AssetCollector information regarding inclusion of CSS

Jonas Eberle CR +2 V +2 Easy +9 −7 updated 02/04/21, 18:14

Commit message

Earlier, documentation erroneously stated that CSS could be moved to
the bottom of <body>. This is not the case (and also not advisable).
Instead, the documentation now reflects that CSS is always output in
the <head>, with "priority"-assets in front of non-"priority".

This also rephrases HTTP/2 information and adds cross-references to
the ViewHelper documentation.

Rendered output:
https://docs.typo3.org/other/typo3/view-helper-reference/master/
en-us/typo3/fluid/latest/Asset/Css.html#priority

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • André Kraus +1
    • Björn Jacob +1
    • Julian Mair +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 815

  1. Jonas Eberle uploaded patch set 1 01/24/21, 11:14

  2. Jonas Eberle uploaded patch set 2 01/24/21, 11:24

  3. TYPO3com voted on patch set 1 V +1 01/24/21, 11:24 Completed build in 10m 07s on Sun, 24 Jan, 11:24 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9021

  4. TYPO3com voted on patch set 2 V -1 01/24/21, 11:25 Completed build in 22s on Sun, 24 Jan, 11:25 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9022

  5. TYPO3com commented on patch set 2 01/24/21, 13:28 Completed build in 19s on Sun, 24 Jan, 01:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9023

  6. Jonas Eberle uploaded patch set 3 01/24/21, 13:33

  7. TYPO3com voted on patch set 3 V -1 01/24/21, 13:43 Completed build in 09m 27s on Sun, 24 Jan, 01:42 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9024

  8. TYPO3com commented on patch set 3 01/24/21, 17:04 Completed build in 10m 17s on Sun, 24 Jan, 05:04 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9027

  9. Julian Mair voted on patch set 3 CR +1 01/25/21, 07:17

  10. André Kraus voted on patch set 3 CR +1 01/26/21, 19:41

  11. TYPO3com commented on patch set 3 01/26/21, 19:58 Completed build in 09m 38s on Tue, 26 Jan, 07:58 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9073

  12. TYPO3com voted on patch set 3 V +1 01/27/21, 08:18 Completed build in 09m 17s on Wed, 27 Jan, 08:18 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9076

  13. Björn Jacob voted on patch set 3 V +1 CR +1 02/04/21, 14:38

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 02/04/21, 18:14

  15. Christian Kuhn merged patch set 4 02/04/21, 18:14