Review main Merged

67519[TASK] Use native PSR-7 Request in Extbase Request building

Benni Mack CR +2 V +2 Normal +86 −82 updated 04/06/21, 13:28

Commit message

Because the original PSR-7 request is now
handed into Extbase at any times, the RequestBuilder
can now utilize a PSR-7 request and does not need
to fall back to global GET/POST or getIndpEnv()
methods anymore.

The final logic in this part is to handle $_FILES,
which needs to be dealt with separately as a feature
toggle.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Simon Gilli +1
    • Markus Klein +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 915

  1. Benni Mack uploaded patch set 1 01/25/21, 08:54

  2. TYPO3com voted on patch set 1 V -1 01/25/21, 09:03 Completed build in 08m 52s on Mon, 25 Jan, 09:03 AM Test Summary: 60 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9031

  3. Benni Mack uploaded patch set 2 01/25/21, 10:19

  4. TYPO3com voted on patch set 2 V -1 01/25/21, 10:29 Completed build in 10m 37s on Mon, 25 Jan, 10:29 AM Test Summary: 45 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9032

  5. Benni Mack uploaded patch set 3 03/17/21, 16:34

  6. TYPO3com voted on patch set 3 V -1 03/17/21, 16:41 Completed build in 07m 19s on Wed, 17 Mar, 04:41 PM Test Summary: 45 of 33143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10194

  7. core-ci voted on patch set 3 V -1 03/17/21, 16:47 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1641

  8. Benni Mack uploaded patch set 4 04/02/21, 10:41

  9. TYPO3com voted on patch set 4 V +1 04/02/21, 10:48 Completed build in 06m 27s on Fri, 2 Apr, 10:48 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10458

  10. core-ci voted on patch set 4 V +1 04/02/21, 10:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1992

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 04/06/21, 08:51

  12. Simon Gilli voted on patch set 4 CR +1 04/06/21, 09:14

  13. Markus Klein commented on patch set 4 CR +1 04/06/21, 09:34

    Lovely
  14. Georg Ringer voted on patch set 4 V +2 CR +2 04/06/21, 13:28

  15. Georg Ringer merged patch set 5 04/06/21, 13:28