Review main Merged

67520[BUGFIX] Fix table header styles in info module

Oli Bartsch CR +2 V +2 Normal +37 −33 updated 01/26/21, 16:13

Commit message

To restore proper distinction between header and body
rows, the table header cells now use the th tag instead of td.

This also fixes a bug which lead to all rows got 0 assigned
as data-uid in the page overview table. Furthermore are
some variables renamed to increase readability.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Oli Bartsch uploaded patch set 1 01/25/21, 12:04

  2. Oli Bartsch uploaded patch set 2 01/25/21, 12:10

  3. TYPO3com voted on patch set 1 V +1 01/25/21, 12:14 Completed build in 09m 40s on Mon, 25 Jan, 12:14 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9035

  4. TYPO3com voted on patch set 2 V +1 01/25/21, 12:19 Completed build in 09m 24s on Mon, 25 Jan, 12:19 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9036

  5. Benni Mack voted on patch set 2 V +1 CR +1 01/25/21, 13:39

  6. Guido Schmechel voted on patch set 2 V +1 CR +1 01/25/21, 20:58

  7. Guido Schmechel commented on patch set 2 01/25/21, 21:03

    Should we just fix the "form-group" at PageTsConfig view or rather create a separate ticket?
  8. Oli Bartsch commented on patch set 2 01/25/21, 21:10

    Reply

    Please let's create a separate issue for this since this patch only deals with the table styles. Maybe there is even more to improve in PageTs. Didn't have a detailed look yet.
  9. Guido Schmechel commented on patch set 2 01/25/21, 21:27

    Reply

    Ack
  10. Benni Mack voted on patch set 2 V +2 CR +2 01/26/21, 16:13

  11. Benni Mack merged patch set 3 01/26/21, 16:13