67521[WIP][BUGFIX] Allow lazy command list
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 15
- typo3/sysext/backend/Classes/Command/LockBackendCommand.php+0 −1
- typo3/sysext/backend/Classes/Command/ReferenceIndexUpdateCommand.php+1 −2
- typo3/sysext/backend/Classes/Command/ResetPasswordCommand.php+0 −1
- typo3/sysext/backend/Classes/Command/UnlockBackendCommand.php+0 −8
- typo3/sysext/backend/Configuration/Services.yaml+4 −4
- typo3/sysext/core/Classes/Command/ExtensionListCommand.php+0 −1
- typo3/sysext/core/Classes/Command/SendEmailCommand.php+0 −1
- typo3/sysext/core/Classes/Command/SiteListCommand.php+0 −8
- typo3/sysext/core/Classes/Command/SiteShowCommand.php+1 −2
- typo3/sysext/core/Classes/Console/CommandApplication.php2+1 −6
- typo3/sysext/core/Classes/Console/ConsoleApplication.phpnew+59 −0
- typo3/sysext/core/Classes/Console/LazyCommand.phpnew+253 −0
- typo3/sysext/core/Classes/DependencyInjection/ConsoleCommandPass.php1+42 −7
- typo3/sysext/core/Configuration/Services.yaml+4 −0
- typo3/sysext/extensionmanager/Configuration/Services.yaml+2 −0
Review log 912
-
Helmut Hummel uploaded patch set 1 01/25/21, 13:05
-
TYPO3com voted on patch set 1 V -1 01/25/21, 13:05 Completed build in 20s on Mon, 25 Jan, 01:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9037
-
Helmut Hummel updated the commit message in patch set 2 01/25/21, 13:16
-
Helmut Hummel uploaded patch set 3 01/25/21, 13:18
-
TYPO3com voted on patch set 2 V -1 01/25/21, 13:18 Completed build in 21s on Mon, 25 Jan, 01:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9038
-
TYPO3com voted on patch set 3 V -1 01/25/21, 13:18 Completed build in 17s on Mon, 25 Jan, 01:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9039
-
Benni Mack commented on patch set 3 01/25/21, 14:21
oh boy, why didn't they just go with PHP8 annotations... (just my 2 cents for the symfony change, not ours) -
Helmut Hummel commented on patch set 3 01/25/21, 19:44
Reply
That is actually the plan. However that would require a sf version that has php 8 as minimum requirement. -
Helmut Hummel commented on patch set 3 01/25/21, 19:48
Reply
we can nevertheless decide differently on details. to me more important is the lux command class, which will solve quite a bunch of issues for us. how the data points are configured should maybe looked at anyway. I'm open for pretty much any suggestion here. -
Benjamin Franzke commented on patch set 3 02/02/21, 14:09
It is a good move to adapt `list` for lazy loading, but I think symfony devs didn't take a good route by introducing this via a LazyCommand wrapper. This would have been much better implemented by a new revision of the CommandLoaderInterface (and should have been part of it in 2017). Anyway, if it is released like that, we'll of course use it. Also "description" as an implicit `lazy` indicator is a bit strange, and I'd personally would have used a separate alias property (anyway, we'll stay with the symfony way, to not confuse developers) What I want so say: This looks a bit premature and I could imagine they may change the details until the final 5.3 release. The pull request actually contained comments that suggested changes: https://github.com/symfony/symfony/pull/39851#pullrequestreview-572147186 Therefore we should wait for this until symfony 5.3 is released and include it in master only. Will also help to avoid the ConsoleApplication->isLazy hack which would be required right now, when using symfony 5.2.CommandApplication.php:64Any special reasion why the context name is dropped from the command name? I'm fine with it, but would prefer noticing it in the commit message, including a reason. -
Benjamin Franzke commented on patch set 3 02/03/21, 12:23
CommandApplication.php:64ReplyOk, I've seen that this is move into ConsoleApplication, now.ConsoleCommandPass.php:94UnresolvedA braindump, so I don't forget this remark: Due to passing 5 parameters here, while LazyCommand accepts 6, this causes all commands to be enabled. (as $isEnable = true is the 6th parameter) That'd be "breaking" for the dumpautoload command, as the command would now always be enabled. Actually we need to think about what we want for the command list. A "complete" command list might be desirable, yes – but during execution of the command, the real `getEnabled()` method would be overloaded/shimmed and therefore not be evaluated. That's something up for discussion. -
Helmut Hummel abandoned the change 02/09/21, 09:35
Abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/67635