Review main Merged

67522[BUGFIX] Fix delegation of toolbar events

Oli Bartsch CR +2 V +2 Easy +4 −4 updated 01/27/21, 08:43

Commit message

In #92704 the module menu got improved. The toolbar
events were delegated to dedicated objects instead
of just delegating to "document".

Since the help menu is not the only toolbar component
using those events, it must be delegated to the whole
toolbar instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Martin Kutschker +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Martin Kutschker +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Oli Bartsch uploaded patch set 1 01/25/21, 14:16

  2. Oli Bartsch updated the commit message in patch set 2 01/25/21, 14:19

  3. TYPO3com voted on patch set 1 V +1 01/25/21, 14:26 Completed build in 09m 47s on Mon, 25 Jan, 02:26 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9040

  4. TYPO3com voted on patch set 2 V +1 01/25/21, 14:36 Completed build in 10m 03s on Mon, 25 Jan, 02:36 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9041

  5. Jochen Roth voted on patch set 2 V +1 CR +1 01/25/21, 14:45

  6. Martin Kutschker voted on patch set 2 CR +1 01/25/21, 16:30

  7. Martin Kutschker voted on patch set 2 V +1 01/25/21, 18:21

  8. Benni Mack voted on patch set 2 V +2 CR +2 01/27/21, 08:43

  9. Benni Mack merged patch set 3 01/27/21, 08:43