Review main Merged

67534[TASK] runTests.sh: Add phpstan and docBlockCheck

Christian Kuhn CR +2 V +2 Normal +53 −3 updated 01/26/21, 12:27

Commit message

Allows:
* Build/Scripts/runTests.sh -s docBlockCheck
* Build/Scripts/runTests.sh -s phpstan

These two have been added to bamboo with #89023, but not to
runTests.sh.

phpstan is tuned a bit to create it's cache in .cache rather
than ephermal /tmp to survive between host reboots.
Additionally the number of max CPU's is restricted in phpstan
to be a better neighbor on local dev machines and on CI.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Simon Gilli +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Simon Gilli +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1114

  1. Christian Kuhn uploaded patch set 1 01/26/21, 11:51

  2. Simon Gilli voted on patch set 1 CR +1 01/26/21, 11:53

  3. Christian Kuhn uploaded patch set 2 01/26/21, 11:54

  4. Simon Gilli voted on patch set 2 CR +1 01/26/21, 11:56

  5. Christian Kuhn uploaded patch set 3 01/26/21, 11:57

  6. Simon Gilli voted on patch set 3 CR +1 01/26/21, 11:58

  7. TYPO3com voted on patch set 1 V +1 01/26/21, 12:00 Completed build in 09m 26s on Tue, 26 Jan, 12:00 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9060

  8. Simon Gilli voted on patch set 3 V +1 01/26/21, 12:06

  9. TYPO3com voted on patch set 2 V +1 01/26/21, 12:07 Completed build in 09m 09s on Tue, 26 Jan, 12:07 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9062

  10. TYPO3com voted on patch set 3 V +1 01/26/21, 12:11 Completed build in 13m 01s on Tue, 26 Jan, 12:11 PM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9063

  11. Jochen Roth voted on patch set 3 V +1 CR +1 01/26/21, 12:23

  12. Anja Leichsenring voted on patch set 3 V +1 CR +1 01/26/21, 12:23

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 01/26/21, 12:27

  14. Christian Kuhn merged patch set 4 01/26/21, 12:27