Review 10.4 Merged

67537[TASK] runTests.sh: Add install on mysql and grunt clean check

Christian Kuhn CR +2 V +2 Normal +74 −0 updated 01/26/21, 15:37

Commit message

Allow:
* Build/Scripts/runTests.sh -s install -d mysql
* Build/Scripts/runTests.sh -s checkGruntClean

The acceptance tests of the install procedure were
missing an option for mysql as opposed to mariadb.

The grunt clean operation compiles everything (js, css, ..)
and verifies no files are changed afterwards. This is mostly
used in CI to ensure patches are pushed using 'current'
yarn/npm dependencies. Note this calls a 'git add', so it
might lead to unexpected git status results if executed
locally.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Christian Kuhn uploaded patch set 1 01/26/21, 13:10

  2. TYPO3com voted on patch set 1 V +1 01/26/21, 13:22 Completed build in 11m 59s on Tue, 26 Jan, 01:22 PM Test Summary: 75356 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1015

  3. Christian Kuhn voted on patch set 1 CR -1 01/26/21, 13:32

  4. Christian Kuhn uploaded patch set 2 01/26/21, 15:19

  5. TYPO3com voted on patch set 2 V +1 01/26/21, 15:31 Completed build in 11m 36s on Tue, 26 Jan, 03:31 PM Test Summary: 75356 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1016

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 01/26/21, 15:37

  7. Christian Kuhn merged patch set 3 01/26/21, 15:37