Review main Merged

67539[BUGFIX] runTests.sh: Fix macos user detection

Jochen Roth CR +2 V +2 Normal +61 −48 updated 02/15/21, 13:16

Commit message

Check for user in /etc/passwd, if it does not exist create
a temporary passwd to get values from.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 1426

Show 1 earlier messages
  1. Jochen Roth uploaded patch set 1 01/26/21, 16:08

  1. Christian Kuhn updated the commit message in patch set 2 01/26/21, 16:12

  2. TYPO3com voted on patch set 1 V -1 01/26/21, 16:17 Completed build in 08m 51s on Tue, 26 Jan, 04:17 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9070

  3. TYPO3com voted on patch set 2 V +1 01/26/21, 16:21 Completed build in 08m 43s on Tue, 26 Jan, 04:21 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9071

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 01/29/21, 10:20

  5. Jochen Roth voted on patch set 2 V +1 CR +1 01/29/21, 10:33

  6. Christian Kuhn commented on patch set 2 CR -1 01/29/21, 12:52

    -1 for a moment: jochen & oli already confirmed the patch works. codewise i'd like to solve it slightly diffrent though, and will push an updated set next days.
  7. Christian Kuhn uploaded patch set 3 02/15/21, 10:53

  8. TYPO3com voted on patch set 3 V +1 02/15/21, 11:02 Completed build in 08m 33s on Mon, 15 Feb, 11:02 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9539

  9. core-ci voted on patch set 3 V -1 02/15/21, 11:04 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/731

  10. Christian Kuhn uploaded patch set 4 02/15/21, 11:54

  11. TYPO3com voted on patch set 4 V +1 02/15/21, 12:02 Completed build in 07m 36s on Mon, 15 Feb, 12:02 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9540

  12. core-ci voted on patch set 4 V -1 02/15/21, 12:04 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/732

  13. Christian Kuhn uploaded patch set 5 02/15/21, 12:19

  14. TYPO3com voted on patch set 5 V +1 02/15/21, 12:27 Completed build in 08m 30s on Mon, 15 Feb, 12:27 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9541

  15. core-ci voted on patch set 5 V +1 02/15/21, 12:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/733

  16. Christian Kuhn uploaded patch set 6 02/15/21, 12:37

  17. TYPO3com voted on patch set 6 V -1 02/15/21, 12:45 Completed build in 08m 19s on Mon, 15 Feb, 12:45 PM Test Summary: 1 of 32862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9542

  18. core-ci voted on patch set 6 V +1 02/15/21, 12:47 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/734

  19. Christian Kuhn uploaded patch set 7 02/15/21, 12:53

  20. Jochen Roth voted on patch set 7 V +1 CR +1 02/15/21, 12:58

  21. TYPO3com voted on patch set 7 V +1 02/15/21, 13:02 Completed build in 08m 25s on Mon, 15 Feb, 01:02 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9543

  22. Oli Bartsch voted on patch set 7 V +1 CR +1 02/15/21, 13:03

  23. core-ci voted on patch set 7 V +1 02/15/21, 13:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/735

  24. Christian Kuhn voted on patch set 7 V +2 CR +2 02/15/21, 13:16

  25. Christian Kuhn merged patch set 8 02/15/21, 13:16