Review main Merged

67541[BUGFIX] Ensure IRRE record selectors show up with maxitems set

Benni Mack CR +2 V +2 Easy +2 −2 updated 01/27/21, 12:49

Commit message

When an IRRE field in FormEngine has maxitems set,
and an item gets removed (thus, allowing an inline element
to be added again), the buttons to create new elements
are shown again.

This fixes a regression introduced with #91595.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jörn Wagner +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jörn Wagner +1
    • TYPO3com +1 CI

Issues 3

Files 2

Review log 711

  1. Benni Mack uploaded patch set 1 01/27/21, 11:21

  2. Benni Mack updated the commit message in patch set 2 01/27/21, 11:23

  3. Benni Mack updated the commit message in patch set 3 01/27/21, 11:23

  4. Benni Mack uploaded patch set 4 01/27/21, 11:28

  5. TYPO3com voted on patch set 1 V -1 01/27/21, 11:34 Completed build in 12m 52s on Wed, 27 Jan, 11:34 AM Test Summary: 31364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9079

  6. TYPO3com voted on patch set 2 V -1 01/27/21, 11:38 Completed build in 15m 03s on Wed, 27 Jan, 11:38 AM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9080

  7. TYPO3com voted on patch set 3 V +1 01/27/21, 11:42 Completed build in 18m 29s on Wed, 27 Jan, 11:42 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9081

  8. TYPO3com voted on patch set 4 V +1 01/27/21, 11:45 Completed build in 10m 16s on Wed, 27 Jan, 11:45 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9082

  9. Jörn Wagner voted on patch set 4 V +1 CR +1 01/27/21, 12:05

  10. Georg Ringer voted on patch set 4 V +2 CR +2 01/27/21, 12:49

  11. Georg Ringer merged patch set 5 01/27/21, 12:49