Review main Merged

67544[TASK] Migrate some PageTree components to TypeScript

Oliver Hader CR +2 V +2 Hard +407 −398 updated 01/29/21, 13:13

Commit message

+ removed NavigationComponentInterface - actually no
  class-like component did implement it
+ introduced TreeInterface, having some aspects
  of previous NavigationComponentInterface
+ aim to use native DOM operations (instead jQuery) where possible
+ switched templating in PageTreeElement and PageTreeToolbar to lit-html

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1321

  1. Oliver Hader uploaded patch set 1 01/28/21, 16:17

  2. Oliver Hader updated the commit message in patch set 2 01/28/21, 16:18

  3. TYPO3com voted on patch set 1 V -1 01/28/21, 16:28 Completed build in 10m 39s on Thu, 28 Jan, 04:28 PM Test Summary: 81 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9084

  4. TYPO3com voted on patch set 2 V -1 01/28/21, 16:30 Completed build in 12m 10s on Thu, 28 Jan, 04:30 PM Test Summary: 80 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9085

  5. Oliver Hader uploaded patch set 3 01/28/21, 20:46

  6. TYPO3com voted on patch set 3 V -1 01/28/21, 20:57 Completed build in 10m 48s on Thu, 28 Jan, 08:57 PM Test Summary: 80 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9091

  7. Oliver Hader commented on patch set 3 01/29/21, 09:46

    Okay... Bamboo fails due to using an old Chrome version... Reason is the implicit same-site behavior for fetch requests in newer Chrome versions → switching to AjaxRequest.ts instead
  8. Oliver Hader uploaded patch set 4 01/29/21, 09:47

  9. TYPO3com voted on patch set 4 V -1 01/29/21, 09:56 Completed build in 08m 49s on Fri, 29 Jan, 09:56 AM Test Summary: 4 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9094

  10. TYPO3com commented on patch set 4 01/29/21, 10:20 Completed build in 41m 14s on Fri, 29 Jan, 10:20 AM Test Summary: 4 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9094

  11. Oliver Hader uploaded patch set 5 01/29/21, 11:45

  12. Oliver Hader voted on patch set 5 CR -1 01/29/21, 11:52

  13. TYPO3com voted on patch set 5 V -1 01/29/21, 11:55 Completed build in 10m 37s on Fri, 29 Jan, 11:55 AM Test Summary: 35 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9097

  14. Oliver Hader commented on patch set 5 01/29/21, 12:03

    PageTreeToolbar.js:84 Unresolved

    That actually never worked, but was overridden by the tree (initialized later)...
  15. Oliver Hader uploaded patch set 6 01/29/21, 12:04

  16. Oliver Hader uploaded patch set 7 01/29/21, 12:12

  17. TYPO3com voted on patch set 6 V -1 01/29/21, 12:16 Completed build in 11m 15s on Fri, 29 Jan, 12:16 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9098

  18. TYPO3com voted on patch set 7 V +1 01/29/21, 12:22 Completed build in 10m 22s on Fri, 29 Jan, 12:22 PM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9099

  19. Benni Mack voted on patch set 7 V +1 CR +1 01/29/21, 12:46

  20. Christian Kuhn voted on patch set 7 V +2 CR +2 01/29/21, 13:12

  21. Christian Kuhn merged patch set 8 01/29/21, 13:13