Review main Merged

67546[BUGFIX] Improve exceptions when BE.adminOnly or BE.IPmaskList is used

Torben Hansen CR +2 V +2 Normal +46 −5 updated 01/31/21, 21:28

Commit message

TYPO3 now returns a HTTP 403 status code, when BE.adminOnly is
configured or when the clients IP address does not match the
configured BE.IPmaskList.

Additionally, TYPO3 will now present a proper system message
instead of showing the default "Oops, an error occurred!".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1118

  1. Torben Hansen uploaded patch set 1 01/28/21, 18:56

  2. TYPO3com voted on patch set 1 V +1 01/28/21, 19:07 Completed build in 11m 07s on Thu, 28 Jan, 07:07 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9089

  3. Benni Mack updated the commit message in patch set 2 01/29/21, 08:23

  4. TYPO3com voted on patch set 2 V -1 01/29/21, 08:33 Completed build in 10m 27s on Fri, 29 Jan, 08:33 AM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9093

  5. Benni Mack commented on patch set 2 01/29/21, 22:27

    Thanks for this fix. Any reason to have this in 9.5 specifically? The change seems non-intrusive but at the same time, it seems it _could_ be fixed manually in a specific project for 9.5, if this is actually necessary. I'd rather not have this in 9.5 as it doesn't seem to qualify as a "critical bugfix". What do you think?
  6. TYPO3com voted on patch set 2 V +1 01/29/21, 22:29 Completed build in 14h 16m 48s on Fri, 29 Jan, 10:29 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9093

  7. Torben Hansen updated the commit message in patch set 3 01/30/21, 06:29

  8. Torben Hansen commented on patch set 3 01/30/21, 06:30

    Reply

    Agree, I updated the commit message.
  9. TYPO3com voted on patch set 3 V +1 01/30/21, 06:40 Completed build in 09m 52s on Sat, 30 Jan, 06:40 AM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9108

  10. Richard Haeser uploaded patch set 4 01/30/21, 11:08

  11. Richard Haeser voted on patch set 4 V +1 CR +1 01/30/21, 11:08

  12. Richard Haeser uploaded patch set 5 01/30/21, 11:11

  13. Richard Haeser voted on patch set 5 V +1 CR +1 01/30/21, 11:11

  14. TYPO3com voted on patch set 4 V +1 01/30/21, 11:19 Completed build in 10m 15s on Sat, 30 Jan, 11:19 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9110

  15. TYPO3com voted on patch set 5 V -1 01/30/21, 11:21 Completed build in 09m 28s on Sat, 30 Jan, 11:21 AM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9111

  16. TYPO3com voted on patch set 5 V +1 01/30/21, 11:34 Completed build in 10m 04s on Sat, 30 Jan, 11:34 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9112

  17. Benni Mack voted on patch set 5 V +2 CR +2 01/31/21, 21:28

  18. Benni Mack merged patch set 6 01/31/21, 21:28