67549[BUGFIX] Avoid double CSH wraps in linkvalidator tasks settings
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Helmut Hummel +1
-
Verified V +2 Done
- Richard Haeser +2
- Sybille Peters +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 79
-
Oliver Hader uploaded patch set 1 01/29/21, 10:56
-
Oliver Hader uploaded patch set 2 01/29/21, 11:05
-
TYPO3com voted on patch set 1 V +1 01/29/21, 11:06 Completed build in 10m 17s on Fri, 29 Jan, 11:06 AM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9095
-
TYPO3com voted on patch set 2 V +1 01/29/21, 11:14 Completed build in 09m 09s on Fri, 29 Jan, 11:14 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9096
-
Helmut Hummel voted on patch set 2 CR +1 01/29/21, 19:38
-
Sybille Peters commented on patch set 2 V +1 01/30/21, 06:05
Not familiar with that part of the code, but the patch does fix the problem :) -
Sybille Peters commented on patch set 2 01/30/21, 06:21
As noted in issue, scheduler task "Execute console commands" also has this problem (\TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask). I would remove the <em> from the language file (is that good practice anyway?), but then the translations may still have this problem: EXT:scheduler/Resources/Private/Language/locallang.xlf: <source><![CDATA[Schedulable Command. <em>Save and reopen to define command arguments</em>]]></source> -
Richard Haeser voted on patch set 2 V +2 CR +2 01/31/21, 07:54
-
Richard Haeser merged patch set 3 01/31/21, 07:54