67572[BUGFIX] Do not try to resolve TypoScript [ELSE] condition
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Stefan Froemken +1
-
Verified V +2 Done
- Richard Haeser +2
- Stefan Froemken +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1114
-
Torben Hansen uploaded patch set 1 01/29/21, 18:41
-
TYPO3com voted on patch set 1 V +1 01/29/21, 18:51 Completed build in 09m 14s on Fri, 29 Jan, 06:51 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9105
-
Benni Mack updated the commit message in patch set 2 01/29/21, 22:40
-
Benni Mack commented on patch set 2 01/29/21, 22:41
good catch, does this also happen to [GLOBAL]? -
TYPO3com voted on patch set 2 V +1 01/29/21, 22:51 Completed build in 09m 57s on Fri, 29 Jan, 10:51 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9107
-
Torben Hansen uploaded patch set 3 01/30/21, 11:54
-
Torben Hansen commented on patch set 3 01/30/21, 12:03
Reply
The Expression Language Resolver currently never tries to resolve GLOBAL or END. I reworked the patch so the error is not catched but to let the expression actually never be evaluated by the Symfony Expression Language. Should we make sure GLOBAL and END are never evaluated too? -
TYPO3com voted on patch set 3 V +1 01/30/21, 12:06 Completed build in 10m 31s on Sat, 30 Jan, 12:06 PM Test Summary: 32603 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9113
-
Richard Haeser commented on patch set 3 V +1 CR +1 01/31/21, 07:25
As far as I can see, GLOBAL and END are already never evaluated isn't it? -
Torben Hansen commented on patch set 3 02/01/21, 07:32
Reply
Yes, at least not currently. -
Richard Haeser commented on patch set 3 02/01/21, 08:27
Reply
As far as I can see, the evaluation of the end and global are never reaching the symfony component so it will only occur when there is a change on our own side. So I would leave it for now. -
Stefan Froemken commented on patch set 3 V +1 CR +1 02/17/21, 18:33
Good position to solve that problem. I have tested this fix with our maps2: https://github.com/jweiland-net/maps2/blob/master/Configuration/TypoScript/OpenStreetMap/setup.txt#L17 Now "nextDivider()" for ELSE will be called again. Good work. -
Richard Haeser voted on patch set 3 V +2 CR +2 02/17/21, 18:41
-
Richard Haeser merged patch set 4 02/17/21, 18:41