67573[BUGFIX] Avoid SQL error in indexed_search statistics
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- Oliver Hader +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 2
Files 1
Review log 1220
-
Benni Mack uploaded patch set 1 01/29/21, 22:20
-
TYPO3com voted on patch set 1 V -1 01/29/21, 22:31 Completed build in 10m 06s on Fri, 29 Jan, 10:31 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9106
-
TYPO3com commented on patch set 1 01/29/21, 22:35 Completed build in 24m 07s on Fri, 29 Jan, 10:35 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9106
-
Tymoteusz Motylewski commented on patch set 1 01/30/21, 21:21
-
Benni Mack commented on patch set 1 02/03/21, 16:35
SearchController.php:863ReplyHaven't tested it yet. At this point, I'd personally say "well, find a search word longer than 50 characters and save only 49.5 characters than having a SQL error" (HTTP Status 500). Of course, we could extend the database field as well, but I try to have that as non-intrusive as possible for bugfix releases. -
Guido Schmechel commented on patch set 1 02/14/21, 18:40
SearchController.php:863Reply UnresolvedMaybe mb_substr is an option? -
Christian Kuhn rebased onto patch set 2 02/15/21, 18:49
-
TYPO3com voted on patch set 2 V +1 02/15/21, 18:58 Completed build in 08m 26s on Mon, 15 Feb, 06:58 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9552
-
Christian Kuhn commented on patch set 3 02/15/21, 18:59
Published edit on patch set 2. -
core-ci voted on patch set 2 V +1 02/15/21, 19:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/745
-
TYPO3com voted on patch set 3 V +1 02/15/21, 19:10 Completed build in 10m 34s on Mon, 15 Feb, 07:10 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9556
-
Christian Kuhn voted on patch set 3 CR -1 02/15/21, 19:14
-
core-ci voted on patch set 3 V +1 02/15/21, 19:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/749
-
Christian Kuhn uploaded patch set 4 02/15/21, 19:25
-
TYPO3com voted on patch set 4 V +1 02/15/21, 19:33 Completed build in 08m 02s on Mon, 15 Feb, 07:33 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9557
-
core-ci voted on patch set 4 V +1 02/15/21, 19:35 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/750
-
Christian Kuhn voted on patch set 4 V +1 CR +1 02/15/21, 19:41
-
Anja Leichsenring voted on patch set 4 V +2 CR +2 02/15/21, 19:42
-
Anja Leichsenring merged patch set 5 02/15/21, 19:42
-
Oliver Hader voted on patch set 5 CR +1 02/15/21, 19:52
SearchController.php:863