Review main Merged

67575[BUGFIX] Decouple id selectors from SvgTree and PageTree

Benni Mack CR +2 V +2 Normal +49 −56 updated 02/01/21, 14:30

Commit message

The PageTree component (added in TYPO3 v9) is based on SVG Tree,
which was added in a previous version (TYPO3 v8).

However, changes like https://review.typo3.org/c/Packages/TYPO3.CMS/+/55878/
unnecessarily coupled the SVG Tree to the PageTree.

In addition, some minor details to NOT use pagetree IDs
everywhere allows to use other SVG-tree based components
in the navigation container in the future.

id=typo3-pagetree-treeContainer is kept for
typo3/testing-framework compatibility, for now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1224

  1. Benni Mack uploaded patch set 1 01/30/21, 23:12

  2. TYPO3com voted on patch set 1 V -1 01/30/21, 23:23 Completed build in 10m 37s on Sat, 30 Jan, 11:23 PM Test Summary: 33 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9114

  3. TYPO3com commented on patch set 1 02/01/21, 06:39 Completed build in 7h 36m 59s on Mon, 1 Feb, 06:39 AM Test Summary: 33 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9114

  4. Benni Mack uploaded patch set 2 02/01/21, 06:51

  5. Benni Mack uploaded patch set 3 02/01/21, 06:59

  6. TYPO3com voted on patch set 2 V -1 02/01/21, 07:00 Completed build in 09m 09s on Mon, 1 Feb, 07:00 AM Test Summary: 33 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9127

  7. TYPO3com voted on patch set 3 V -1 02/01/21, 07:10 Completed build in 10m 27s on Mon, 1 Feb, 07:10 AM Test Summary: 33 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9128

  8. Benjamin Franzke uploaded patch set 4 02/01/21, 11:21

  9. Benjamin Franzke uploaded patch set 5 02/01/21, 11:31

  10. TYPO3com voted on patch set 4 V -1 02/01/21, 11:35 Completed build in 13m 08s on Mon, 1 Feb, 11:35 AM Test Summary: 34 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9133

  11. TYPO3com voted on patch set 5 V -1 02/01/21, 11:45 Completed build in 13m 15s on Mon, 1 Feb, 11:45 AM Test Summary: 13 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9135

  12. Benjamin Franzke uploaded patch set 6 02/01/21, 12:02

  13. TYPO3com voted on patch set 6 V -1 02/01/21, 12:12 Completed build in 09m 33s on Mon, 1 Feb, 12:12 PM Test Summary: 13 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9136

  14. Benjamin Franzke uploaded patch set 7 02/01/21, 13:38

  15. TYPO3com voted on patch set 7 V -1 02/01/21, 13:48 Completed build in 09m 41s on Mon, 1 Feb, 01:48 PM Test Summary: 4 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9141

  16. TYPO3com commented on patch set 7 02/01/21, 14:01 Completed build in 32m 22s on Mon, 1 Feb, 02:01 PM Test Summary: 4 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9141

  17. Richard Haeser uploaded patch set 8 02/01/21, 14:02

  18. Richard Haeser uploaded patch set 9 02/01/21, 14:06

  19. TYPO3com voted on patch set 8 V -1 02/01/21, 14:12 Completed build in 09m 32s on Mon, 1 Feb, 02:12 PM Test Summary: 7 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9143

  20. TYPO3com voted on patch set 9 V -1 02/01/21, 14:16 Completed build in 08m 46s on Mon, 1 Feb, 02:16 PM Test Summary: 5 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9144

  21. Benjamin Franzke uploaded patch set 10 02/01/21, 14:17

  22. TYPO3com voted on patch set 10 V +1 02/01/21, 14:27 Completed build in 09m 35s on Mon, 1 Feb, 02:27 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9146

  23. Benni Mack voted on patch set 10 V +2 CR +2 02/01/21, 14:30

  24. Benni Mack merged patch set 11 02/01/21, 14:30