Review main Merged

67576[DOCS] Added condition to snippet for social media fallback images

Richard Haeser CR +2 V +2 Easy +2 −0 updated 01/31/21, 15:25

Commit message

It is possible to have multiple og:image meta tags by the specs. By
adding the condition to your TypoScript setup, the fallback images for
social media will only be rendered when no image is set in the page
properties. This will prevent that the fallback image is always
rendered even when an image is set in the backend.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Martin Kutschker +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Martin Kutschker +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Richard Haeser uploaded patch set 1 01/31/21, 10:52

  2. TYPO3com voted on patch set 1 V +1 01/31/21, 11:05 Completed build in 11m 22s on Sun, 31 Jan, 11:04 AM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9115

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 01/31/21, 11:25

  4. Martin Kutschker voted on patch set 1 V +1 CR +1 01/31/21, 15:25

  5. Richard Haeser voted on patch set 1 V +2 CR +2 01/31/21, 15:25

  6. Richard Haeser merged patch set 2 01/31/21, 15:25