67578[FEATURE] Add Folder Tree as SVG Tree with filter
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Georg Ringer +1
-
Verified V +2 Done
- Richard Haeser +2
- Georg Ringer +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 23
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/FileStorageTree.tsnew+272 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/FileStorageTreeActions.tsnew+298 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/FileStorageTreeContainer.ts4new+154 −0
- typo3/sysext/backend/Classes/Controller/File/FileController.php+22 −1
- typo3/sysext/backend/Classes/Controller/FileStorage/TreeController.phpnew+181 −0
- typo3/sysext/backend/Classes/Tree/FileStorageTreeProvider.phpnew+286 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −7
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+14 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_layout.xlf+3 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageTree.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageTreeActions.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageTreeContainer.jsnew+38 −0
- typo3/sysext/backend/ext_tables.php+3 −0
- typo3/sysext/core/Classes/Imaging/Icon.php+2 −2
- typo3/sysext/core/Documentation/Changelog/master/Feature-93426-SVG-basedTreeForFolderNavigationWithFilter.rstnew+61 −0
- typo3/sysext/core/Resources/Private/Language/locallang_misc.xlf+6 −0
- typo3/sysext/core/Tests/Acceptance/Backend/FileList/FileStorageTreeFilterCest.phpnew+106 −0
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/FalMetadataCest.php+5 −4
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/NavigationComponentTreeCest.php+12 −10
- typo3/sysext/core/Tests/Acceptance/Support/Helper/FileTree.phpnew+40 −0
Review log 4287
Show 2562 earlier messages
-
Benni Mack uploaded patch set 1 02/01/21, 10:08
-
TYPO3com voted on patch set 1 V -1 02/01/21, 10:20 Completed build in 11m 36s on Mon, 1 Feb, 10:20 AM Test Summary: 7 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9132
-
Benni Mack uploaded patch set 2 02/01/21, 14:55
-
TYPO3com voted on patch set 2 V -1 02/01/21, 15:13 Completed build in 16m 50s on Mon, 1 Feb, 03:13 PM Test Summary: 5 of 30111 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9152
-
Benni Mack uploaded patch set 3 02/01/21, 15:50
-
TYPO3com voted on patch set 3 V -1 02/01/21, 16:02 Completed build in 11m 33s on Mon, 1 Feb, 04:02 PM Test Summary: 7 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9158
-
Benni Mack uploaded patch set 4 02/02/21, 18:33
-
TYPO3com voted on patch set 4 V -1 02/02/21, 18:41 Completed build in 07m 26s on Tue, 2 Feb, 06:41 PM Test Summary: 5 of 26405 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9201
-
Benni Mack uploaded patch set 5 02/02/21, 20:44
-
TYPO3com voted on patch set 5 V -1 02/02/21, 20:52 Completed build in 07m 01s on Tue, 2 Feb, 08:52 PM Test Summary: 4 of 22711 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9205
-
TYPO3com commented on patch set 5 02/03/21, 18:03 Completed build in 07m 08s on Wed, 3 Feb, 06:03 PM Test Summary: 7 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9226
-
Anja Leichsenring uploaded patch set 6 02/03/21, 18:07
-
TYPO3com voted on patch set 6 V -1 02/03/21, 18:13 Completed build in 06m 18s on Wed, 3 Feb, 06:13 PM Test Summary: 2 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9227
-
TYPO3com commented on patch set 6 02/03/21, 18:16 Completed build in 16m 00s on Wed, 3 Feb, 06:16 PM Test Summary: 2 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9227
-
TYPO3com commented on patch set 6 02/03/21, 18:21 Completed build in 30m 12s on Wed, 3 Feb, 06:21 PM Test Summary: 2 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9227
-
Anja Leichsenring uploaded patch set 7 02/03/21, 19:23
-
TYPO3com voted on patch set 7 V -1 02/03/21, 19:24 Completed build in 12s on Wed, 3 Feb, 07:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9229
-
Anja Leichsenring uploaded patch set 8 02/03/21, 19:24
-
TYPO3com voted on patch set 8 V +1 02/03/21, 19:31 Completed build in 06m 55s on Wed, 3 Feb, 07:31 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9230
-
Benni Mack uploaded patch set 9 02/03/21, 21:55
-
TYPO3com voted on patch set 9 V +1 02/03/21, 22:01 Completed build in 06m 25s on Wed, 3 Feb, 10:01 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9240
-
Benni Mack updated the commit message in patch set 10 02/03/21, 22:37
-
TYPO3com voted on patch set 10 V +1 02/03/21, 22:44 Completed build in 06m 52s on Wed, 3 Feb, 10:44 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9242
-
Benni Mack uploaded patch set 11 02/09/21, 15:06
-
TYPO3com voted on patch set 11 V -1 02/09/21, 15:16 Completed build in 09m 55s on Tue, 9 Feb, 03:16 PM Test Summary: 1 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9400
-
core-ci voted on patch set 11 V -1 02/09/21, 15:18 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/537
-
Benni Mack uploaded patch set 12 02/09/21, 21:40
-
TYPO3com voted on patch set 12 V -1 02/09/21, 21:41 Completed build in 17s on Tue, 9 Feb, 09:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9419
-
core-ci voted on patch set 12 V +1 02/09/21, 21:52 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/557
-
Benni Mack uploaded patch set 13 02/10/21, 12:06
-
TYPO3com voted on patch set 13 V -1 02/10/21, 12:07 Completed build in 21s on Wed, 10 Feb, 12:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9437
-
core-ci voted on patch set 13 V -1 02/10/21, 12:23 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/579
-
Benni Mack uploaded patch set 14 02/10/21, 15:34
-
TYPO3com voted on patch set 14 V -1 02/10/21, 15:42 Completed build in 07m 52s on Wed, 10 Feb, 03:42 PM Test Summary: 32598 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9441
-
core-ci voted on patch set 14 V -1 02/10/21, 15:51 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/586
-
Benni Mack uploaded patch set 15 02/10/21, 16:10
-
TYPO3com voted on patch set 15 V -1 02/10/21, 16:19 Completed build in 09m 04s on Wed, 10 Feb, 04:19 PM Test Summary: 1 of 32841 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9443
-
core-ci voted on patch set 15 V -1 02/10/21, 16:21 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/591
-
Benni Mack uploaded patch set 16 02/10/21, 16:40
-
TYPO3com voted on patch set 16 V -1 02/10/21, 16:49 Completed build in 08m 52s on Wed, 10 Feb, 04:49 PM Test Summary: 1 of 32841 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9444
-
core-ci voted on patch set 16 V -1 02/10/21, 16:51 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/594
-
Benni Mack uploaded patch set 17 02/10/21, 20:05
-
TYPO3com voted on patch set 17 V -1 02/10/21, 20:13 Completed build in 07m 35s on Wed, 10 Feb, 08:13 PM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9449
-
core-ci voted on patch set 17 V -1 02/10/21, 20:15 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/606
-
Benni Mack uploaded patch set 18 02/10/21, 20:22
-
TYPO3com voted on patch set 18 V -1 02/10/21, 20:22 Completed build in 11s on Wed, 10 Feb, 08:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9450
-
core-ci voted on patch set 18 V -1 02/10/21, 20:23 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/607
-
Benni Mack uploaded patch set 19 02/11/21, 08:32
-
TYPO3com voted on patch set 19 V +1 02/11/21, 08:40 Completed build in 07m 54s on Thu, 11 Feb, 08:40 AM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9456
-
core-ci voted on patch set 19 V +1 02/11/21, 08:42 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/632
-
Richard Haeser commented on patch set 19 02/11/21, 13:43
Really awesome change! Found some small UX wise issues after "playing" a bit with this feature: - Tree does not update after creating or renaming a folder - Moving folders with same parent (so changing order) is giving strange effect. it will move it into the folder you have chosen to put the folder below. Is it possible to disable moving within same parent? Otherwise we might want to disable drag / drop here I guess. - No update of page tree after cut / paste - Filtering on non-existing string shows just the current state. In the page tree you just don’t see any page. I think this should be consistent. - When filtering you can’t open subfolders anymore (which won’t match the filter). Not the same experience as in the page tree - I sometime have issues that I need to refresh the tree to get the items visible. Can't find a way to reproduce though. -
Benni Mack uploaded patch set 20 02/15/21, 10:17
-
TYPO3com voted on patch set 20 V +1 02/15/21, 10:26 Completed build in 08m 35s on Mon, 15 Feb, 10:26 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9538
-
core-ci voted on patch set 20 V +1 02/15/21, 10:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/730
-
Richard Haeser uploaded patch set 21 02/15/21, 13:21
-
Richard Haeser commented on patch set 21 V -1 02/15/21, 13:23
We still need to take care of the ability to expand a folder that meets the search filter. Now you see the arrow, but can't expand it (as the sub folder doesn't meet the search filter). Will work on that tonight. -
TYPO3com voted on patch set 21 V +1 02/15/21, 13:30 Completed build in 08m 35s on Mon, 15 Feb, 01:30 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9547
-
core-ci voted on patch set 21 V +1 02/15/21, 13:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/738
-
Benni Mack uploaded patch set 22 02/15/21, 14:45
-
TYPO3com voted on patch set 22 V +1 02/15/21, 14:54 Completed build in 08m 35s on Mon, 15 Feb, 02:54 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9548
-
core-ci voted on patch set 22 V +1 02/15/21, 14:56 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/741
-
Richard Haeser uploaded patch set 23 02/15/21, 19:36
-
Richard Haeser commented on patch set 23 02/15/21, 19:37
FileStorageTreeContainer.ts:53The tree was not refreshed after changes. Not sure if this is the right way to do so. -
Richard Haeser voted on patch set 23 V +1 CR +1 02/15/21, 19:38
-
TYPO3com voted on patch set 23 V +1 02/15/21, 19:44 Completed build in 07m 45s on Mon, 15 Feb, 07:44 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9558
-
core-ci voted on patch set 23 V +1 02/15/21, 19:47 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/751
-
Christian Kuhn commented on patch set 23 CR -1 02/15/21, 20:47
-1 for the moment, had some details with benni directly. btw: cool thing! -
Benni Mack commented on patch set 23 02/16/21, 06:40
Reply
Missing: * Acceptance Tests * Flash Message when a folder was moved / copied -
Benni Mack commented on patch set 23 02/16/21, 07:45
FileStorageTreeContainer.ts:53ReplyWith this change, the tree gets refreshed (and blinks) on every click. -
Richard Haeser commented on patch set 23 V 0 CR 0 02/16/21, 08:21
FileStorageTreeContainer.ts:53ReplyYeah, I saw indeed. Will look for a better way -
Benni Mack uploaded patch set 24 02/16/21, 09:26
-
TYPO3com voted on patch set 24 V -1 02/16/21, 09:26 Completed build in 15s on Tue, 16 Feb, 09:26 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9563
-
Benni Mack commented on patch set 24 02/16/21, 09:27
Updated the patch: * Added flash messages when drag&drop * Fixed updating tree when renaming a folder in the filelist * Added tests for the filter -
core-ci voted on patch set 24 V -1 02/16/21, 09:27 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/764
-
Benni Mack uploaded patch set 25 02/16/21, 09:28
-
TYPO3com voted on patch set 25 V +1 02/16/21, 09:35 Completed build in 07m 44s on Tue, 16 Feb, 09:35 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9564
-
core-ci voted on patch set 25 V +1 02/16/21, 09:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/765
-
Richard Haeser commented on patch set 25 V +1 CR +1 02/16/21, 11:09
FileStorageTreeContainer.ts:53ReplyDone -
Richard Haeser commented on patch set 25 02/16/21, 11:14
Reply
Done -
Oli Bartsch commented on patch set 25 V -1 02/16/21, 13:55
I encounter strange behaviour when using keyboard navigation. There is unfortunately not that one way to reproduce. But after some time closing and reopening folders leads to all sub folders are duplicated, or folders pop up at a completely different location in the tree. The most efficient way I found to reproduce it, close and reopen a file storage - the root folder (maybe multiple times). This then often duplicated all its subfolders. I also sometimes lost the focus in the tree and it's then hard to get it back since it "jumps" to a random part of the module. Side note: I have a basic setup with two file storages and some sub folders (which may contain other sub folders). -
Benni Mack uploaded patch set 26 02/17/21, 11:17
-
TYPO3com voted on patch set 26 V +1 02/17/21, 11:25 Completed build in 07m 48s on Wed, 17 Feb, 11:25 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9587
-
core-ci voted on patch set 26 V +1 02/17/21, 11:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/796
-
Georg Ringer voted on patch set 26 V +1 CR +1 02/17/21, 11:56
-
Richard Haeser commented on patch set 26 V +1 CR +1 02/17/21, 12:46
@Oliver do you want to check the keyboard access again? I have no issues anymore. -
Richard Haeser commented on patch set 26 V +2 CR +2 02/17/21, 12:52
Reply
Also checked on another install now and everything works fine -
Richard Haeser merged patch set 27 02/17/21, 12:52