67579[BUGFIX] Migrate carousel classes within the MultiStepWizard component
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Riccardo De Contardi +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 810
-
Ralf Zimmermann uploaded patch set 1 02/01/21, 11:25
-
TYPO3com voted on patch set 1 V -1 02/01/21, 11:40 Completed build in 14m 17s on Mon, 1 Feb, 11:40 AM Test Summary: 1 of 32095 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9134
-
Georg Ringer commented on patch set 1 02/01/21, 11:51
the generated JS file must be commited as well -
Ralf Zimmermann uploaded patch set 2 02/01/21, 12:18
-
Ralf Zimmermann commented on patch set 2 02/01/21, 12:20
Reply
yes of course, thank you -
TYPO3com voted on patch set 2 V +1 02/01/21, 12:29 Completed build in 10m 05s on Mon, 1 Feb, 12:29 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9137
-
Riccardo De Contardi commented on patch set 2 V +1 02/06/21, 15:38
without the patch: the first step of the wizard presents a spinner always visible; the second page presents TWO spinners and it impossible to finish the wizard. with the patch: everything works. The only issue remaining is the position of the progress bar but I think it will get fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/67627 -
Andreas Kienast voted on patch set 2 V +1 CR +1 02/06/21, 15:58
-
Benni Mack voted on patch set 2 V +2 CR +2 02/06/21, 21:16
-
Benni Mack merged patch set 3 02/06/21, 21:16