Review main Merged

67583[TASK] Remove jQuery from Tree components

Benni Mack CR +2 V +2 Hard +140 −176 updated 02/09/21, 10:16

Commit message

This change aims to reduce the overhead by using
jQuery in favor of Vanilla JS in various Tree-related
JS files in preparation for a TypeScript migration.

* SvgTree.js
* SelectTree.js
* PageTree.js
* PageTreeToolbar.ts
* PageTreeElement.ts
* TreeToolbar.ts

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Richard Haeser +1

Issues 1

Files 10

Review log 1833

Show 48 earlier messages
  1. Benni Mack uploaded patch set 1 02/01/21, 15:34

  2. TYPO3com voted on patch set 1 V -1 02/01/21, 15:45 Completed build in 10m 16s on Mon, 1 Feb, 03:45 PM Test Summary: 36 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9156

  3. Benni Mack uploaded patch set 2 02/01/21, 20:54

  4. TYPO3com voted on patch set 2 V -1 02/01/21, 21:05 Completed build in 10m 18s on Mon, 1 Feb, 09:05 PM Test Summary: 8 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9178

  5. Benni Mack uploaded patch set 3 02/01/21, 21:39

  6. Benni Mack uploaded patch set 4 02/01/21, 21:44

  7. TYPO3com voted on patch set 4 V -1 02/01/21, 22:10 Completed build in 18m 27s on Mon, 1 Feb, 10:10 PM Test Summary: 2 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9185

  8. TYPO3com voted on patch set 3 V -1 02/01/21, 22:22 Completed build in 30m 50s on Mon, 1 Feb, 10:22 PM Test Summary: 1 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9183

  1. TYPO3com commented on patch set 4 02/01/21, 22:23 Completed build in 50m 00s on Mon, 1 Feb, 10:23 PM Test Summary: 1 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9185

  2. Benni Mack uploaded patch set 5 02/02/21, 12:24

  3. TYPO3com voted on patch set 5 V -1 02/02/21, 12:35 Completed build in 10m 52s on Tue, 2 Feb, 12:35 PM Test Summary: 1 of 32293 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9192

  4. Benni Mack updated the commit message in patch set 6 02/03/21, 12:24

  5. TYPO3com voted on patch set 6 V -1 02/03/21, 12:33 Completed build in 08m 15s on Wed, 3 Feb, 12:33 PM Test Summary: 1 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9210

  6. Benni Mack uploaded patch set 7 02/03/21, 20:48

  7. TYPO3com voted on patch set 7 V -1 02/03/21, 20:58 Completed build in 07m 18s on Wed, 3 Feb, 08:58 PM Test Summary: 1 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9236

  8. Benni Mack commented on patch set 7 02/03/21, 22:14

    SvgTree.js:266 Unresolved

    looks like this is an issue now... showing up the failing tests.
  9. Benni Mack uploaded patch set 8 02/03/21, 22:34

  10. TYPO3com voted on patch set 8 V +1 02/03/21, 22:42 Completed build in 07m 52s on Wed, 3 Feb, 10:42 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9241

  11. Benni Mack updated the commit message in patch set 9 02/04/21, 07:21

  12. TYPO3com voted on patch set 9 V +1 02/04/21, 07:29 Completed build in 06m 58s on Thu, 4 Feb, 07:29 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9243

  13. Benjamin Franzke uploaded patch set 10 02/04/21, 10:03

  14. TYPO3com voted on patch set 10 V -1 02/04/21, 10:09 Completed build in 06m 41s on Thu, 4 Feb, 10:09 AM Test Summary: 1 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9250

  15. TYPO3com voted on patch set 10 V +1 02/04/21, 10:26 Completed build in 05m 57s on Thu, 4 Feb, 10:26 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9251

  16. Benjamin Franzke uploaded patch set 11 02/04/21, 11:47

  17. TYPO3com voted on patch set 11 V +1 02/04/21, 11:54 Completed build in 06m 58s on Thu, 4 Feb, 11:54 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9255

  18. Benjamin Franzke uploaded patch set 12 02/04/21, 11:56

  19. TYPO3com voted on patch set 12 V +1 02/04/21, 12:03 Completed build in 06m 39s on Thu, 4 Feb, 12:03 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9257

  20. Benjamin Franzke uploaded patch set 13 02/04/21, 13:05

  21. Georg Ringer voted on patch set 13 V +2 CR +2 02/04/21, 13:11

  22. Georg Ringer merged patch set 14 02/04/21, 13:11

  23. TYPO3com voted on patch set 13 V +1 02/04/21, 13:11 Completed build in 06m 21s on Thu, 4 Feb, 01:11 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9258

  24. Richard Haeser voted on patch set 14 V +1 CR +1 02/04/21, 13:12

  25. Oliver Hader commented on patch set 14 02/09/21, 10:02

    SvgTree.js:460 Unresolved

    Does not work... should be assigned to `node`