Review main Merged

67585[BUGFIX] Re-allow rendering of IRRE subitems in Workspaces GridView

Benni Mack CR +2 V +2 Easy +29 −5 updated 02/03/21, 16:06

Commit message

In previous TYPO3 versions (until the Workspace module was refactored
in TYPO3 v8) it was possible to manipulate the collapse / expand
toggle via Signals (now PSR-14 event), for third-party
records with a lot of IRRE records.

This change re-introduces the toggle for PSR-14 event listeners
to respond to the JavaScript toggle / flag.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1319

  1. Benni Mack uploaded patch set 1 02/01/21, 16:40

  2. TYPO3com voted on patch set 1 V +1 02/01/21, 16:52 Completed build in 11m 21s on Mon, 1 Feb, 04:52 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9159

  3. Benni Mack updated the commit message in patch set 2 02/01/21, 20:08

  4. TYPO3com voted on patch set 2 V +1 02/01/21, 20:19 Completed build in 10m 20s on Mon, 1 Feb, 08:19 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9173

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 02/02/21, 11:41

  6. Richard Haeser commented on patch set 2 CR +1 02/02/21, 13:52

    Any example EventListener to more easily verify?
  7. Benni Mack uploaded patch set 3 02/02/21, 20:22

  8. Benni Mack commented on patch set 3 02/02/21, 20:22

    Optimized the change, but also created a quick extension as demonstration: https://github.com/bmack/typo3-issue-tester/tree/issue_93396
  9. TYPO3com voted on patch set 3 V -1 02/02/21, 20:35 Completed build in 12m 22s on Tue, 2 Feb, 08:35 PM Test Summary: 1 of 25684 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9203

  10. TYPO3com commented on patch set 3 02/02/21, 20:48 Completed build in 38m 34s on Tue, 2 Feb, 08:48 PM Test Summary: 1 of 26165 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9203

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 02/03/21, 08:56

  12. Oli Bartsch uploaded patch set 4 02/03/21, 12:35

  13. TYPO3com voted on patch set 4 V -1 02/03/21, 12:36 Completed build in 12s on Wed, 3 Feb, 12:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9211

  14. Oli Bartsch uploaded patch set 5 02/03/21, 12:37

  15. TYPO3com voted on patch set 5 V +1 02/03/21, 12:47 Completed build in 08m 45s on Wed, 3 Feb, 12:46 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9212

  16. Oli Bartsch voted on patch set 5 V +1 CR +1 02/03/21, 14:31

  17. Christian Kuhn voted on patch set 5 V +1 CR +1 02/03/21, 14:40

  18. Benni Mack voted on patch set 5 V +2 CR +2 02/03/21, 16:06

  19. Benni Mack merged patch set 6 02/03/21, 16:06