Review main Merged

67586[BUGFIX] Drop UTF-8 BOM on some files

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 02/01/21, 18:35

Commit message

Some documentation related files contain a UTF-8 BOM
while they shouldn't.
Usually, script Build/Scripts/checkUtf8Bom.sh tests
for this in CI. The script however fails in CI
currently, since the PHP test container doesn't have
gnu file shell command installed. Seems nobody saw
the according error message and due to the xargs
construct the test does not fail.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Christian Kuhn uploaded patch set 1 02/01/21, 17:01

  2. TYPO3com voted on patch set 1 V +1 02/01/21, 17:11 Completed build in 09m 17s on Mon, 1 Feb, 05:11 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9160

  3. Stephan Großberndt updated the commit message in patch set 2 02/01/21, 17:35

  4. TYPO3com voted on patch set 2 V +1 02/01/21, 17:47 Completed build in 11m 30s on Mon, 1 Feb, 05:47 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9162

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 02/01/21, 18:24

  6. Simon Gilli voted on patch set 2 V +1 CR +1 02/01/21, 18:30

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 02/01/21, 18:34

  8. Christian Kuhn merged patch set 3 02/01/21, 18:35