Review 10.4 Merged

67587[BUGFIX] Drop UFT-8 BOM on some files

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 02/01/21, 18:35

Commit message

Some documentation related files contain a UTF-8 BOM
while they shouldn't.
Usually, script Build/Scripts/checkUtf8Bom.sh tests
for this in CI. The script however fails in CI
currently, since the PHP test container doesn't have
gnu file shell command installed. Seems nobody saw
the according error message and due to the xargs
construct the test does not fail.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 47

  1. Christian Kuhn uploaded patch set 1 02/01/21, 17:03

  2. TYPO3com voted on patch set 1 V -1 02/01/21, 17:16 Completed build in 12m 08s on Mon, 1 Feb, 05:16 PM Test Summary: 2 of 75841 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1027

  3. Christian Kuhn updated the commit message in patch set 2 02/01/21, 17:47

  4. TYPO3com voted on patch set 1 V +1 02/01/21, 17:51 Completed build in 59m 26s on Mon, 1 Feb, 05:51 PM Test Summary: 75354 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1027

  5. TYPO3com voted on patch set 2 V +1 02/01/21, 18:08 Completed build in 16m 04s on Mon, 1 Feb, 06:08 PM Test Summary: 75356 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1028

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 02/01/21, 18:35

  7. Christian Kuhn merged patch set 3 02/01/21, 18:35