67589[TASK] Refactor client-side FlexForm handling
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Richard Haeser +1
-
Verified V +2 Done
- Benni Mack +2
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 20
- Build/Sources/Sass/typo3/_element_panel.scss+1 −1
- Build/Sources/Sass/typo3/_element_tceforms.scss+1 −12
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Container/FlexFormContainerContainer.tsnew+159 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Container/FlexFormSectionContainer.tsnew+206 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/FlexForm/FlexFormElementOptions.tsdeleted+0 −29
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineFlexForm.tsdeleted+0 −280
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/SecurityUtility.ts+5 −0
- Build/Sources/TypeScript/core/Tests/SecurityUtilityTest.ts+5 −0
- Build/types/TYPO3/index.d.ts+0 −2
- typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php+47 −31
- typo3/sysext/backend/Classes/Form/Container/FlexFormEntryContainer.php+1 −4
- typo3/sysext/backend/Classes/Form/Container/FlexFormSectionContainer.php2+14 −5
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/FlexFormContainerContainer.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/FlexFormSectionContainer.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/FlexForm/FlexFormElementOptions.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineFlexForm.jsdeleted+0 −13
- typo3/sysext/core/Resources/Public/JavaScript/SecurityUtility.js+1 −1
- typo3/sysext/core/Tests/JavaScript/SecurityUtilityTest.js+1 −1
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+1 −1
Review log 2859
Show 1634 earlier messages
-
Andreas Kienast uploaded patch set 1 02/01/21, 17:34
-
TYPO3com voted on patch set 1 V -1 02/01/21, 17:35 Completed build in 22s on Mon, 1 Feb, 05:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9161
-
Andreas Kienast uploaded patch set 2 02/05/21, 11:11
-
TYPO3com voted on patch set 2 V -1 02/05/21, 11:11 Completed build in 17s on Fri, 5 Feb, 11:11 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9290
-
Andreas Kienast uploaded patch set 3 02/05/21, 11:12
-
TYPO3com voted on patch set 3 V -1 02/05/21, 11:13 Completed build in 11s on Fri, 5 Feb, 11:12 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9291
-
core-ci voted on patch set 3 V -1 02/05/21, 11:13 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/408
-
Andreas Kienast uploaded patch set 4 02/05/21, 13:40
-
TYPO3com voted on patch set 4 V -1 02/05/21, 13:47 Completed build in 07m 19s on Fri, 5 Feb, 01:47 PM Test Summary: 1 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9294
-
core-ci voted on patch set 4 V +1 02/05/21, 13:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/411
-
Andreas Kienast uploaded patch set 5 02/05/21, 15:52
-
Andreas Kienast uploaded patch set 6 02/05/21, 15:54
-
TYPO3com voted on patch set 5 V +1 02/05/21, 16:00 Completed build in 07m 40s on Fri, 5 Feb, 04:00 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9299
-
TYPO3com voted on patch set 6 V -1 02/05/21, 16:00 Completed build in 06m 28s on Fri, 5 Feb, 04:00 PM Test Summary: 15354 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9300
-
core-ci voted on patch set 5 V +1 02/05/21, 16:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/416
-
core-ci voted on patch set 6 V +1 02/05/21, 16:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/417
-
Andreas Kienast uploaded patch set 7 02/05/21, 18:19
-
TYPO3com voted on patch set 7 V -1 02/05/21, 18:27 Completed build in 08m 08s on Fri, 5 Feb, 06:27 PM Test Summary: 5 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9312
-
Andreas Kienast uploaded patch set 8 02/06/21, 15:31
-
Andreas Kienast uploaded patch set 9 02/06/21, 15:35
-
TYPO3com voted on patch set 8 V -1 02/06/21, 15:38 Completed build in 07m 02s on Sat, 6 Feb, 03:38 PM Test Summary: 2 of 32827 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9325
-
TYPO3com voted on patch set 9 V +1 02/06/21, 15:43 Completed build in 07m 49s on Sat, 6 Feb, 03:43 PM Test Summary: 32586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9326
-
Andreas Kienast uploaded patch set 10 02/06/21, 15:46
-
Andreas Kienast uploaded patch set 11 02/06/21, 15:47
-
Andreas Kienast uploaded patch set 12 02/06/21, 15:51
-
TYPO3com voted on patch set 10 V -1 02/06/21, 15:55 Completed build in 09m 22s on Sat, 6 Feb, 03:55 PM Test Summary: 2 of 32827 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9327
-
TYPO3com voted on patch set 11 V +1 02/06/21, 15:56 Completed build in 08m 46s on Sat, 6 Feb, 03:56 PM Test Summary: 32586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9328
-
TYPO3com voted on patch set 12 V +1 02/06/21, 15:59 Completed build in 08m 16s on Sat, 6 Feb, 03:59 PM Test Summary: 32586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9329
-
Andreas Kienast uploaded patch set 13 02/06/21, 16:39
-
TYPO3com voted on patch set 13 V +1 02/06/21, 16:48 Completed build in 08m 59s on Sat, 6 Feb, 04:48 PM Test Summary: 32586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9330
-
Andreas Kienast commented on patch set 13 CR -2 02/06/21, 16:53
This should wait for https://review.typo3.org/c/Packages/TYPO3.CMS/+/67658 -
Andreas Kienast uploaded patch set 14 02/06/21, 21:24
-
Andreas Kienast updated the commit message in patch set 15 02/06/21, 21:24
-
TYPO3com voted on patch set 14 V -1 02/06/21, 21:24 Completed build in 20s on Sat, 6 Feb, 09:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9335
-
TYPO3com voted on patch set 15 V -1 02/06/21, 21:24 Completed build in 20s on Sat, 6 Feb, 09:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9336
-
Andreas Kienast uploaded patch set 16 02/06/21, 21:26
-
Andreas Kienast voted on patch set 16 CR 0 02/06/21, 21:30
-
TYPO3com voted on patch set 16 V +1 02/06/21, 21:34 Completed build in 07m 49s on Sat, 6 Feb, 09:34 PM Test Summary: 32586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9337
-
core-ci voted on patch set 14 V +1 02/06/21, 21:36 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/450
-
core-ci voted on patch set 16 V +1 02/06/21, 21:44 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/452
-
core-ci voted on patch set 15 V +1 02/06/21, 21:44 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/451
-
Andreas Kienast uploaded patch set 17 02/12/21, 15:17
-
TYPO3com voted on patch set 17 V +1 02/12/21, 15:24 Completed build in 07m 44s on Fri, 12 Feb, 03:24 PM Test Summary: 32612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9505
-
core-ci voted on patch set 17 V +1 02/12/21, 15:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/691
-
Andreas Kienast uploaded patch set 18 02/12/21, 21:17
-
TYPO3com voted on patch set 18 V +1 02/12/21, 21:25 Completed build in 08m 21s on Fri, 12 Feb, 09:25 PM Test Summary: 32612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9513
-
core-ci voted on patch set 18 V +1 02/12/21, 21:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/699
-
Andreas Kienast uploaded patch set 19 02/15/21, 07:44
-
TYPO3com voted on patch set 19 V +1 02/15/21, 07:53 Completed build in 09m 37s on Mon, 15 Feb, 07:53 AM Test Summary: 32612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9528
-
core-ci voted on patch set 19 V +1 02/15/21, 07:56 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/719
-
Benni Mack commented on patch set 19 02/15/21, 08:36
FlexFormSectionContainer.php:98just by reading: do we need "data-bs-target"? -
Andreas Kienast commented on patch set 19 02/15/21, 08:45
FlexFormSectionContainer.php:98Reply UnresolvedThis `data-target` is unrelated to Bootstrap :). This "target" is used in TypeScript to determine where to put newly created sections. -
Benni Mack voted on patch set 19 V +1 CR +1 02/15/21, 08:50
-
Andreas Kienast uploaded patch set 20 02/15/21, 08:55
-
Richard Haeser voted on patch set 20 V +1 CR +1 02/15/21, 09:01
-
TYPO3com voted on patch set 20 V +1 02/15/21, 09:04 Completed build in 08m 13s on Mon, 15 Feb, 09:04 AM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9532
-
Benni Mack voted on patch set 20 V +2 CR +2 02/15/21, 09:04
-
Benni Mack merged patch set 21 02/15/21, 09:04
-
core-ci voted on patch set 20 V +1 02/15/21, 09:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/722