Review main Merged

67590[BUGFIX] Make ext:form previous step button work again

Ralf Zimmermann CR +2 V +2 Easy +34 −2 updated 04/22/21, 06:08

Commit message

Since #92815 the extbase request dispatcher sets an "original
request" within a subrequest in case of a "ForwardResponse".

The fluid AbstractFormFieldViewHelper::hasMappingErrorOccurred()
guesses that a property mapping error exists as soon as a request
is a subrequest. This is determined by the fact that the current
request has a original request (e.g. if a controller returns a
ForwardResponse).

While the determination of "property mapping error exists" based
on the existence of a parent request may not be the best indicator,
it seems to be fine for EXT:form for now.

EXT:form makes further use of the HiddenViewHelper to set the previous
page index as a value for the property "__currentPage". Since this
ViewHelper always sets the respectSubmittedDataValue property to TRUE,
the value is always overwritten in case a parent request exists and
the "previous step" button did not longer work.

This is now fixed by making the respectSubmittedDataValue property
configurable via a ViewHelper argument and setting in to FALSE for
the "__currentPage" field.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 1117

  1. Ralf Zimmermann uploaded patch set 1 02/01/21, 17:44

  2. Ralf Zimmermann updated the commit message in patch set 2 02/01/21, 17:46

  3. TYPO3com voted on patch set 1 V -1 02/01/21, 17:54 Completed build in 09m 51s on Mon, 1 Feb, 05:54 PM Test Summary: 1 of 32842 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9163

  4. TYPO3com voted on patch set 2 V +1 02/01/21, 18:03 Completed build in 10m 44s on Mon, 1 Feb, 06:03 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9165

  5. Oli Bartsch uploaded patch set 3 04/20/21, 14:07

  6. Oli Bartsch uploaded patch set 4 04/20/21, 14:10

  7. Oli Bartsch voted on patch set 4 V +1 CR +1 04/20/21, 14:11

  8. TYPO3com voted on patch set 3 V +1 04/20/21, 14:15 Completed build in 07m 48s on Tue, 20 Apr, 02:15 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10760

  9. TYPO3com voted on patch set 4 V +1 04/20/21, 14:17 Completed build in 06m 43s on Tue, 20 Apr, 02:17 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10762

  10. core-ci voted on patch set 3 V +1 04/20/21, 14:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2371

  11. core-ci voted on patch set 4 V +1 04/20/21, 14:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2373

  12. Jochen Roth commented on patch set 4 V -1 04/20/21, 14:53

    I'm getting this when i klick on "previous step", the session with the id `991feb31b465e776dc749be850c0d19b3526b274ed2f1f6b11209827694ecda2` was already created accroding to the database ``` Session could not be written to database: An exception occurred while executing 'INSERT INTO `fe_sessions` (`ses_id`, `ses_data`, `ses_userid`, `ses_iplock`, `ses_tstamp`) VALUES (?, ?, ?, ?, ?)' with params ["991feb31b465e776dc749be850c0d19b3526b274ed2f1f6b11209827694ecda2", "a:1:{s:36:\"tx_form_honeypot_name_test-241page-1\";s:21:\"5JGqyHtu6RSvMKCD1ck0O\";}", 0, "[DISABLED]", 1618930127]: Duplicate entry '991feb31b465e776dc749be850c0d19b3526b274ed2f1f6b11209827694ecda2' for key 'PRIMARY' ```
  13. Oli Bartsch commented on patch set 4 04/20/21, 14:55

    Reply

    Thanks for the report but this is not related to this patch: see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67637
  14. Jochen Roth commented on patch set 4 V +1 CR +1 04/20/21, 15:01

    Reply

    Thanks for the information
  15. Wouter Wolters voted on patch set 4 CR +1 04/20/21, 19:13

  16. Benni Mack voted on patch set 4 V +2 CR +2 04/22/21, 06:08

  17. Benni Mack merged patch set 5 04/22/21, 06:08