Review 9.5 Merged

67616[TASK] Drop two unit tests that heavily rely on environment

Christian Kuhn CR +2 V +2 Normal +0 −124 updated 02/01/21, 18:48

Commit message

* The file permission related LocalDriverTest basically test
  getPermissions() that is a set of native PHP methods that
  are hard to mock properly and don't need to be tested in
  our application.

* The DateViewHelperTest relies on a working locale which
  fails on some environments and gives no error output if
  it fails.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Christian Kuhn uploaded patch set 1 02/01/21, 18:19

  2. Christian Kuhn uploaded patch set 2 02/01/21, 18:22

  3. TYPO3com voted on patch set 1 V -1 02/01/21, 18:24 Completed build in 37s on Mon, 1 Feb, 06:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-966

  4. TYPO3com voted on patch set 2 V +1 02/01/21, 18:48 Completed build in 24m 15s on Mon, 1 Feb, 06:48 PM Test Summary: 75298 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-967

  5. Andreas Kienast voted on patch set 2 V +2 CR +2 02/01/21, 18:48

  6. Andreas Kienast merged patch set 3 02/01/21, 18:48