Review main Merged

67618[BUGFIX] Fix PageTree drag-end animation

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 02/01/21, 20:11

Commit message

During the migration to d3 v6 in #93394
one event listener was forgotten to be
updated for the changes callback signature
in d3 v6. The caused the event coordinates,
instead of the node coordinates to be used
for drag-end calculation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 34

  1. Benjamin Franzke uploaded patch set 1 02/01/21, 19:25

  2. TYPO3com voted on patch set 1 V +1 02/01/21, 19:36 Completed build in 11m 00s on Mon, 1 Feb, 07:36 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9171

  3. Benni Mack voted on patch set 1 V +2 CR +2 02/01/21, 20:11

  4. Benni Mack merged patch set 2 02/01/21, 20:11