Review main Merged

67619[TASK] runTests.sh: Switch to a new set of test images

Christian Kuhn CR +2 V +2 Normal +54 −60 updated 02/01/21, 20:36

Commit message

New images are to be found on official TYPO3
https://hub.docker.com/u/typo3 account.

Most images are based on alpine instead of ubuntu and
are thus significantly smaller than the old ones. For
example, the php 7.4 image is now ~170MB instead of ~500MB.

Image definitions are found and maintained at
https://gitlab.typo3.org/core-testing/testing-infrastructure/

* typo3/core-testing-phpXY: Images based on the official
  PHP alpine builds, extended with commands and modules
  we need.

* typo3/core-testing-js: Image based on official node
  image, with current yarn.

* typo3/core-testing-js-chrome: As above, but with chrome
  for javascript unit testing.

* typo3/core-testing-mssql2019: Image for microsoft sql
  server that includes a brutal hack to force sql server
  is fine if databases are located on a tmpfs (CI does that).

* postgres/XY-alpine: Drop-in replacement using the -alpine
  version that is ~1/3 in size.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +2
    • Simon Gilli +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 02/01/21, 20:04

  2. Simon Gilli voted on patch set 1 V +1 CR +1 02/01/21, 20:14

  3. TYPO3com voted on patch set 1 V -1 02/01/21, 20:16 Completed build in 11m 10s on Mon, 1 Feb, 08:16 PM Test Summary: 1 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9172

  4. TYPO3com voted on patch set 1 V +1 02/01/21, 20:26 Completed build in 32m 41s on Mon, 1 Feb, 08:26 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9172

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 02/01/21, 20:34

  6. Andreas Kienast voted on patch set 1 V +1 CR +2 02/01/21, 20:35

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 02/01/21, 20:36

  8. Christian Kuhn merged patch set 2 02/01/21, 20:36